No deserialize #1281
Open
No deserialize #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Python 2.7 tests are failing until #1298 is applied. This change passes Python 3.x tests. |
|
@rgov thanks for the heads up, I had no idea frankly why it was failing. |
f421bf1
to
4b840a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you submit this PR, please make sure that you meet these criteria
If you made a new function, did you write a good docstring for it?
I attempted so, I didn't add anything to the README.
Did you write a test for your new code?
I have not, I could use some pointers.
Did you make sure this code actually works on Lambda, as well as locally?
Yes, I tested this on Lambda it works as expected.
Did you test this code with both Python 2.7 and Python 3.6?
Only 3.6, I can test it out on 2.7.
Description
This adds another kwarg to async.task
deserializewhich controls what arguments are passed to the user defined function. It follows the design ofcapture_responsevery closely.This was simple to implement and try out that I went ahead and did it. Otherwise I would have waited to see how others felt about it in my original ticket.
GitHub Issues
#1270