Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runtime.md #4515

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update runtime.md #4515

wants to merge 2 commits into from

Conversation

ARBUCHELI
Copy link

"period of time" is redundant. It would be better to say only period, because all periods are periods of time.

Description

Issue Solved

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@ARBUCHELI
Update runtime.md
68419f7 
"period of time" is redundant.  It would be better to say only period, because all periods are periods of time.
@CLAassistant
Copy link

CLAassistant commented Apr 15, 2024 •
edited

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dakshdeepHERE
❌ ARBUCHELI
You have signed the CLA already but the status is still pending? Let us recheck it.

@mohitO12-dev mohitO12-dev self-assigned this Apr 30, 2024
@mohitO12-dev mohitO12-dev added typo Fixing a typo status: under review Issue or PR is currently being reviewed new entry New entry or entries documentation Improvements or additions to documentation docs Docs community entries labels Apr 30, 2024
mohitO12-dev
mohitO12-dev approved these changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@mohitO12-dev mohitO12-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All perfect.

@mohitO12-dev mohitO12-dev added status: review 1️⃣ completed and removed status: under review Issue or PR is currently being reviewed new entry New entry or entries labels May 5, 2024
@dakshdeepHERE dakshdeepHERE added the status: under review Issue or PR is currently being reviewed label May 6, 2024
@dakshdeepHERE dakshdeepHERE self-requested a review May 6, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohitO12-dev mohitO12-dev mohitO12-dev approved these changes

@dakshdeepHERE dakshdeepHERE Awaiting requested review from dakshdeepHERE

Assignees

@mohitO12-dev mohitO12-dev

Labels
docs Docs community entries documentation Improvements or additions to documentation status: review 1️⃣ completed status: under review Issue or PR is currently being reviewed typo Fixing a typo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ARBUCHELI @CLAassistant @mohitO12-dev @dakshdeepHERE