Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add goimports #1549

Merged
merged 1 commit into from
Oct 1, 2023
Merged

add goimports #1549

merged 1 commit into from
Oct 1, 2023

Conversation

OneOfOne
Copy link
Contributor

@OneOfOne OneOfOne commented Oct 1, 2023

No description provided.

@folke folke merged commit e8ab2ff into LazyVim:main Oct 1, 2023
3 checks passed
@folke
Copy link
Collaborator

folke commented Oct 1, 2023

Thanks!

@Jomik
Copy link
Contributor

Jomik commented Oct 2, 2023

Why isn't this handled through gopls as well? 😅
https://github.com/golang/tools/blob/master/gopls/doc/settings.md#local-string

May actually personally prefer that they are done through conform, as it becomes a bit clearer. Wonder if there is a good reason to do it through gopls? Performance?

@folke
Copy link
Collaborator

folke commented Oct 2, 2023

I don't use Go at all, but that doc states:

local is the equivalent of the goimports -local flag

So as far as I understand it is similar to goimports with that option, but it is not goimports itself.

@OneOfOne OneOfOne deleted the add-go-imports-back branch October 2, 2023 15:10
@OneOfOne
Copy link
Contributor Author

OneOfOne commented Oct 2, 2023

@Jomik for whatever reason gopls doesn't handle automatic imports in nvim, where it does in vscode, I didn't look much into it but I use the exact same config for gopls in both vscode and nvim and it works in vscode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants