bug: full freeze of Neovim on file reload #1581

emersonford · 2023-10-04T08:31:26Z

Did you check docs and existing issues?

I have read all the LazyVim docs
I have searched the existing issues of LazyVim
I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.9.1 & 0.9.2

Operating system/version

Linux & macOS Sonoma

Describe the bug

I've been experiencing what effectively feels like a deadlock on file reloads after updating to the latest version of LazyVim. I'm fairly confident this is due to LazyVim as I am able to consistently reproduce the issue with:

require("lazy").setup({
  spec = {
    -- add LazyVim and import its plugins
    { "LazyVim/LazyVim", import = "lazyvim.plugins", commit = "f1ce07510d2048e33fec2b609814d68a7175d591" },
    -- import/override with your plugins
    { import = "plugins" },
  },
  ...
})

but am not able to reproduce the issue when I use the immediate previous commit 364bcf325d91a06e6bd6516bdfed84399566cdb6.

I've been trying to get a sense of what exactly is triggering this deadlock-like behavior, but haven't had much luck. The farthest I've gotten is using:

debug.sethook(function()
        local file = io.open("/home/emersonford/Downloads/nvim_bt", "a")
        file:write(debug.traceback("backtrace"))
        file:close()
end, "c", 43)

which spits out a file dominated by the following callstack:

/usr/share/nvim/runtime/lua/vim/treesitter/_fold.lua:190: in function 'get_folds_levels'
/usr/share/nvim/runtime/lua/vim/treesitter/_fold.lua:249: in function 'fn'
/usr/share/nvim/runtime/lua/vim/treesitter/_fold.lua:236: in function </usr/share/nvim/runtime/lua/vim/treesitter/_fold.lua:232

I do see a comment about infinite recursion here: https://github.com/neovim/neovim/blob/1e7e9ee91f73c62b8c5ba9dbdabba3a3b6dc0130/runtime/lua/vim/treesitter/_fold.lua#L280

not sure if this is related?

Steps To Reproduce

Open a file with formatting issues.
Run formatter outside of Neovim (e.g. cargo fmt in a separate tmux pane).
Neovim should now be completely unresponsive, only way to quit Neovim is with kill -9.

Expected Behavior

Neovim should not freeze.

The text was updated successfully, but these errors were encountered:

folke · 2023-10-04T08:41:54Z

This it not a LazyVim issue.
Might be related to this setting: vim.opt.foldexpr = "v:lua.vim.treesitter.foldexpr()".

Report an issue upstream if that's what's causing it.

davidsteinberger · 2023-10-04T11:17:56Z

I just ran into the same. It is indeed caused/realted to value of vim.opt.foldmethod.
Setting this to vim.opt.foldmethod = "manual" in options.lua fixes it for me at the expense of not having folds.
How do others deal with that?

folke · 2023-10-04T11:20:05Z

It's clearly a bug.
Make sure to report an issue in the Neovim repo. I can't reproduce this.

folke · 2023-10-04T15:07:03Z

Can you try to see if Nightly solved this? If so I will change the defaults so that it only is enabled on nightly.

@delice0 same for you

fredrikaverpil · 2023-10-04T15:12:07Z

FWIW, I've been experiencing freezes today as well, but I'm not at my computer at the moment.

folke · 2023-10-04T15:12:10Z

This seems to have been fixed in this PR: neovim/neovim#24230 (comment)

folke · 2023-10-04T15:12:42Z

If someone can confirm it works on nightly, then I'll just disable the feature for now on 0.9.x

folke · 2023-10-04T15:15:23Z

@fredrikaverpil are you on 0.9.2 or a recent nightly?

idelice · 2023-10-04T15:17:38Z

vim.opt.foldmethod = "manual"

I'm not sure what "nightly" means in this context, but vim.opt.foldmethod = "manual" fixed it for me for now.

folke · 2023-10-04T15:19:36Z

That's not a fix. With nightly I mean on Neovim nightly. So a recent NEovim build.

fredrikaverpil · 2023-10-04T15:25:15Z

@fredrikaverpil are you on 0.9.2 or a recent nightly?

0.9.2

jyuan0 · 2023-10-04T15:40:51Z

@folke seems to be working on nightly (commit: 248305cf3). I formatted a simple Rust file with cargo fmt outside of Neovim, and Neovim is still responsive.

folke · 2023-10-04T15:45:43Z

@jyuan0 and you get freezes on 0.9.2 as well?

I can't reproduce it on either at the moment.

jyuan0 · 2023-10-04T15:48:35Z

@jyuan0 and you get freezes on 0.9.2 as well?

Sorry, I don't have a build of 0.9.2 handy for testing.

kingedward35 · 2023-10-04T15:57:08Z

I also experience the same issue and I am on 0.9.2.

folke · 2023-10-04T15:59:36Z

Still the same. I need someone to confirm:

it freezes on 0.9.2
it does not freeze on 0.10 (nightly)

Alternatively if someone can give me steps to reproduce I can test it myself.

kingedward35 · 2023-10-04T16:01:18Z

I don't know if this will help, but I can see the issue after I update to the latest version of LazyVim and then restart NeoVim and open a file. I don't see it when the splash screen shows up upon opening, but only when I open a file. Hope that helps. And thanks.

folke · 2023-10-04T16:08:45Z

I just pushed a changed to enable treesitter folding only on 0.10

kevintraver · 2023-10-04T16:47:51Z

Working again in 0.9.2

Still freezes in 0.10

Specifically when opening telescope symbols require("telescope.builtin").lsp_document_symbols() in a larger file (5000 lines)

folke · 2023-10-04T17:09:39Z

just tested with a 12000 lines lua file and have no issues

davidsteinberger · 2023-10-04T20:02:20Z

@folke here's a repro that breaks for me on neovim 0.9.2.

repro.lua:

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
	vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

require("lazy").setup({
	spec = {
		-- add LazyVim and import its plugins
		{ "LazyVim/LazyVim", commit = "3849e0150b0a616dbd6e7e12ec5025aff6c81d39", import = "lazyvim.plugins" },
		-- { "LazyVim/LazyVim", commit = "d989ecc943b3240db0be3aa0369b96089cee4b40", import = "lazyvim.plugins" },
		-- import any extras modules here
		{ import = "lazyvim.plugins.extras.lang.typescript" },
	},
})

echo '{}' > test.json
nvim -u repro.lua test.json

Then in Lazyvim execute command :e.
Note: d989ecc fixes it for me in neovim 0.9.2.

folke · 2023-10-04T20:18:50Z

Great, thanks! I can reproduce this on 0.9.2.

It works correctly on 0.10.0, so all good :)

dannyfritz · 2023-10-05T02:14:57Z

Probably not the most useful comment, but I was dealing with this at work today and was just logging on now to report it. Glad to see it is sorted out already. I tested LazyVim 9.0.2 on Neovim 0.9.2 and can also confirm all is well here. :)

clason · 2023-10-12T15:43:03Z

Pro tip: not reporting bugs ensures that they will never be fixed (or the fix backported, in this case).

folke · 2023-10-12T15:53:09Z

Right, didn't think about backporting. Thanks!

neovim/neovim#25608 LazyVim/LazyVim#1581

emersonford added the bug Something isn't working label Oct 4, 2023

folke closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2023

folke reopened this Oct 4, 2023

folke mentioned this issue Oct 4, 2023

bug: Freeze when opening any projects e.g. java, lua, react with neovim with latest update LazyVim #1584

Closed

3 tasks

folke closed this as completed in d989ecc Oct 4, 2023

github-actions bot mentioned this issue Oct 4, 2023

chore(main): release 9.0.1 #1585

Merged

clason mentioned this issue Oct 12, 2023

Neovim hangs when an open buffer is modified externally and foldexpr is enabled. neovim/neovim#25608

Closed

jeffutter added a commit to jeffutter/nixpkgs that referenced this issue Nov 1, 2023

Disable Folding due to nvim bug

24d509f

neovim/neovim#25608 LazyVim/LazyVim#1581

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug: full freeze of Neovim on file reload #1581

bug: full freeze of Neovim on file reload #1581

emersonford commented Oct 4, 2023 •

edited

folke commented Oct 4, 2023

davidsteinberger commented Oct 4, 2023

folke commented Oct 4, 2023

folke commented Oct 4, 2023

fredrikaverpil commented Oct 4, 2023

folke commented Oct 4, 2023

folke commented Oct 4, 2023

folke commented Oct 4, 2023

idelice commented Oct 4, 2023

folke commented Oct 4, 2023

fredrikaverpil commented Oct 4, 2023

jyuan0 commented Oct 4, 2023

folke commented Oct 4, 2023

jyuan0 commented Oct 4, 2023 •

edited

kingedward35 commented Oct 4, 2023

folke commented Oct 4, 2023 •

edited

kingedward35 commented Oct 4, 2023

folke commented Oct 4, 2023

kevintraver commented Oct 4, 2023

folke commented Oct 4, 2023

davidsteinberger commented Oct 4, 2023 •

edited

folke commented Oct 4, 2023

dannyfritz commented Oct 5, 2023

clason commented Oct 12, 2023

folke commented Oct 12, 2023

bug: full freeze of Neovim on file reload #1581

bug: full freeze of Neovim on file reload #1581

Comments

emersonford commented Oct 4, 2023 • edited

Did you check docs and existing issues?

Neovim version (nvim -v)

Operating system/version

Describe the bug

Steps To Reproduce

Expected Behavior

folke commented Oct 4, 2023

davidsteinberger commented Oct 4, 2023

folke commented Oct 4, 2023

folke commented Oct 4, 2023

fredrikaverpil commented Oct 4, 2023

folke commented Oct 4, 2023

folke commented Oct 4, 2023

folke commented Oct 4, 2023

idelice commented Oct 4, 2023

folke commented Oct 4, 2023

fredrikaverpil commented Oct 4, 2023

jyuan0 commented Oct 4, 2023

folke commented Oct 4, 2023

jyuan0 commented Oct 4, 2023 • edited

kingedward35 commented Oct 4, 2023

folke commented Oct 4, 2023 • edited

kingedward35 commented Oct 4, 2023

folke commented Oct 4, 2023

kevintraver commented Oct 4, 2023

folke commented Oct 4, 2023

davidsteinberger commented Oct 4, 2023 • edited

folke commented Oct 4, 2023

dannyfritz commented Oct 5, 2023

clason commented Oct 12, 2023

folke commented Oct 12, 2023

emersonford commented Oct 4, 2023 •

edited

jyuan0 commented Oct 4, 2023 •

edited

folke commented Oct 4, 2023 •

edited

davidsteinberger commented Oct 4, 2023 •

edited