fix(keymaps): no diagnostic keymaps w/o lsp attached #1698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometime, a buffer has a linter but does not have lsp attached (e.g bash/zsh file with shellcheck only). Some diagnostic keymaps are not available in those case since they are registered with LSP only.
I propose to move diagnostic keymaps to the more general keymaps file similar to formatting and inlay_hint functionality.