Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] sendMessage name is both required and never #837

Closed
3 tasks done
monarchwadia opened this issue Dec 3, 2023 · 6 comments · Fixed by PlasmoHQ/docs#93
Closed
3 tasks done

[BUG] sendMessage name is both required and never #837

monarchwadia opened this issue Dec 3, 2023 · 6 comments · Fixed by PlasmoHQ/docs#93
Labels
bug Something isn't working

Comments

@monarchwadia
Copy link

monarchwadia commented Dec 3, 2023 •
edited

What happened?

seems related to #528 as well as to #503

I'm following the example in https://docs.plasmo.com/framework/messaging#message-flow

image

However, my code doesn't work if name is declared; nor does it work with name undeclared

image

image

Version

Latest

What OS are you seeing the problem on?

Windows

What browsers are you seeing the problem on?

No response

Relevant log output

No response

(OPTIONAL) Contribution

  • I would like to fix this BUG via a PR

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@monarchwadia monarchwadia added the bug Something isn't working label Dec 3, 2023
@monarchwadia
Copy link
Author

monarchwadia commented Dec 3, 2023 •
edited

Okay, I found a section here that explains things

https://docs.plasmo.com/framework/messaging#initial-type-error

image

Maybe having a reference to it in the initial example itself would help?

@louisgv
Copy link
Contributor

louisgv commented Dec 3, 2023

@monarchwadia that'd be great I think :-?

@monarchwadia
Copy link
Author

I can fix it up in a few. :-)

@monarchwadia monarchwadia mentioned this issue Dec 3, 2023
Merged
@monarchwadia
Copy link
Author

@louisgv see PlasmoHQ/docs#93

@kingname
Copy link

The same issue. still exists. And the method of "Initial Type Error" in doc is useless.

image image

@kingname
Copy link

Thanks. I have solved this problem by your new document. @monarchwadia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plasmo framework messaging docs clarification monarchwadia/docs
3 participants
@monarchwadia @kingname @louisgv