Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add support for match_origin_as_fallback and match_about_blank manifest content script flags #899

Closed
2 of 4 tasks
xiata opened this issue Feb 22, 2024 · 0 comments · Fixed by #900
Closed
2 of 4 tasks
Labels
enhancement New feature or request

Comments

@xiata
Copy link

xiata commented Feb 22, 2024

How do you envision this feature/change to look/work like?

Related Chrome documentation

Two flags are missing from PlasmoCSConfig in 0.84.2 that affect inject-ability of content scripts into related frames:

  • match_origin_as_fallback: boolean
  • match_about_blank: boolean

Including these two variables in PlasmoCSConfig will allow content scripts to possibly inject into, e.g. blob:https://www.test.com. These flags likely won't commonly be used, but nevertheless should be added for completeness. I don't know if these are chrome only, but they are important enough to add for chrome builds.

Note that I could not verify canary release due to an error:

pnpm i plasmo@canary
 ERR_PNPM_NO_MATCHING_VERSION  No matching version found for plasmo@canary

What is the purpose of this change/feature? Why?

It's a missing feature that is supported by Chrome to allow extensions to inject into related frames that involve uncommon protocols (about:, blob:, data:)

(OPTIONAL) Example implementations

No response

(OPTIONAL) Contribution

  • I would like to contribute to this RFC via a PR

Verify canary release

  • I verified that the issue exists in plasmo canary release

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant