Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable IDE0030: UseCoalesceExpressionForNullable #14289

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Enable IDE0030: UseCoalesceExpressionForNullable #14289

merged 2 commits into from
Jul 13, 2021

Conversation

xtqqczze
Copy link
Contributor

@ghost ghost assigned rjmholt Nov 29, 2020
@xtqqczze xtqqczze marked this pull request as ready for review November 29, 2020 14:34
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 29, 2020
@xtqqczze
Copy link
Contributor Author

Relates to #13791.

@xtqqczze xtqqczze marked this pull request as draft December 2, 2020 11:53
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 5, 2020
@xtqqczze xtqqczze marked this pull request as ready for review December 11, 2020 21:55
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 11, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 19, 2020
@ghost
Copy link

ghost commented Dec 19, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator

iSazonov commented Apr 13, 2021 •
edited

I would rather not merge this and close it until the analyzers are fixed otherwise it will have to be fixed a second time.

@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 13, 2021
@xtqqczze
Copy link
Contributor Author

I would rather not merge this and close it until the analyzers are fixed otherwise it will have to be fixed a second time.

@iSazonov I don't think there is an issue with the IDE0030 analyzer - it is working as designed. If a new analyzer is approved to prefer Nullable<T>.GetValueOrDefault() as a result of dotnet/runtime#33792 we could consider new changes in that instance.

@ghost ghost added the Review - Needed The PR is being reviewed label Apr 21, 2021
@ghost
Copy link

ghost commented Apr 21, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Contributor Author

rebased

@rjmholt
Copy link
Collaborator

rjmholt commented Jun 24, 2021

/azp run

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 24, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@ghost ghost added the Review - Needed The PR is being reviewed label Jul 2, 2021
@ghost
Copy link

ghost commented Jul 2, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@rjmholt rjmholt merged commit 00bc0f6 into PowerShell:master Jul 13, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 13, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.8 milestone Jul 13, 2021
@xtqqczze xtqqczze deleted the IDE0030 branch July 14, 2021 12:12
@ghost
Copy link

ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSazonov iSazonov iSazonov left review comments

@rjmholt rjmholt rjmholt approved these changes

Assignees

@rjmholt rjmholt

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xtqqczze @iSazonov @rjmholt