Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ControlSequenceLength to handle colon VT param separators #14942

Conversation

jazzdelightsme
Copy link
Contributor

@jazzdelightsme jazzdelightsme commented Mar 4, 2021

The ControlSequenceLength function calculates the length of a VT control
sequence--used by LengthInBufferCells. SGR control sequences might have
parameters, separated by semicolons... or possibly colons. See:

microsoft/terminal#4321

This change updates ControlSequenceLength to treat colons similarly to
semicolons.

PR Summary

PR Context

PR Checklist

The ControlSequenceLength function calculates the length of a VT control
sequence--used by LengthInBufferCells. SGR control sequences might have
parameters, separated by semicolons... or possibly colons. See:

microsoft/terminal#4321

This change updates ControlSequenceLength to treat colons similarly to
semicolons.
@iSazonov
Copy link
Collaborator

iSazonov commented Mar 8, 2021

/azp run PowerShell-CI-static-analysis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the Review - Needed The PR is being reviewed label Mar 16, 2021
@ghost
Copy link

ghost commented Mar 16, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw
Copy link
Member

/azp run PowerShell-CI-static-analysis

@ghost ghost removed the Review - Needed The PR is being reviewed label May 5, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@daxian-dbw daxian-dbw merged commit 32a38fc into PowerShell:master May 6, 2021
@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label May 26, 2021
@ghost
Copy link

ghost commented May 27, 2021

🎉v7.2.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants