Fix tab completion for unlocalized about* topics #15265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
reviewed
Apr 19, 2021
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Apr 19, 2021
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
Comment on lines
6280
to
6283
| Path.Combine(userHelpDir, currentCulture), | ||
| Path.Combine(userHelpDir, "en-US"), | ||
| Path.Combine(appHelpDir, currentCulture), | ||
| Path.Combine(appHelpDir, "en-US") |
There was a problem hiding this comment.
For discussion:
Suggested change
| Path.Combine(userHelpDir, currentCulture), | |
| Path.Combine(userHelpDir, "en-US"), | |
| Path.Combine(appHelpDir, currentCulture), | |
| Path.Combine(appHelpDir, "en-US") | |
| Path.Combine(userHelpDir, currentCulture), | |
| Path.Combine(appHelpDir, currentCulture), | |
| Path.Combine(userHelpDir, "en-US"), | |
| Path.Combine(appHelpDir, "en-US") |
Maybe users want to get topics in their language first?
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
adityapatwardhan
requested changes
Apr 20, 2021
iSazonov
approved these changes
Apr 21, 2021
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
adityapatwardhan
approved these changes
May 5, 2021
|
@MartinGC94 Thank you for your contribution! |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tab completion for help topics on systems without localized help by adding en-US as a fallback.
Get-Help About<Tab>PR Context
Get-Help will automatically fall back to en-US help topics so the completion for it should do the same.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).