Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CA2243: Attribute string literals should parse correctly #15622

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Fix CA2243: Attribute string literals should parse correctly #15622

merged 3 commits into from
Jun 25, 2021

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jun 20, 2021 •
edited

@ghost ghost assigned iSazonov Jun 20, 2021
@iSazonov iSazonov requested a review from sdwheeler June 21, 2021 05:03
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 21, 2021
@sdwheeler
Copy link
Collaborator

The cmdlet and HelpURI need to be added to the appropriate CSV file in test\powershell\engine\Help\assets\HelpURI.

There are CSV files:

  • V2Cmdlets.csv
  • V3Cmdlets.csv

I don't know the difference between them, but my guess is that it goes in the V2 file.

@xtqqczze
Copy link
Contributor Author

The cmdlet and HelpURI need to be added to the appropriate CSV file in test\powershell\engine\Help\assets\HelpURI.

There are CSV files:

  • V2Cmdlets.csv
  • V3Cmdlets.csv

I don't know the difference between them, but my guess is that it goes in the V2 file.

@adityapatwardhan Do you know which CSV file the HelpUri should be added to?

@xtqqczze xtqqczze closed this Jun 24, 2021
@xtqqczze xtqqczze reopened this Jun 24, 2021
@iSazonov
Copy link
Collaborator

@xtqqczze Please add to V2 file since it is V2 cmdlet.

@xtqqczze
Copy link
Contributor Author

@xtqqczze Please add to V2 file since it is V2 cmdlet.

Added in 6d147e5.

@iSazonov iSazonov merged commit 756aef9 into PowerShell:master Jun 25, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.8 milestone Jun 25, 2021
@xtqqczze xtqqczze deleted the CA2243 branch June 25, 2021 13:04
@ghost
Copy link

ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jul 22, 2021
Closed
@adityapatwardhan
Copy link
Member

I think this does not meet the bar backport, but i wanted to have discussion as the issue for this PR was marked backport to 7.1.x

@adityapatwardhan adityapatwardhan added the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label May 24, 2022
@adityapatwardhan adityapatwardhan removed Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers BackPort-7.0.x-Consider labels Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSazonov iSazonov iSazonov approved these changes

@sdwheeler sdwheeler Awaiting requested review from sdwheeler

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees

@iSazonov iSazonov

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.8
Development

Successfully merging this pull request may close these issues.

Add missing Remove-Alias HelpUri
4 participants
@xtqqczze @sdwheeler @iSazonov @adityapatwardhan