Enable signing daily release build with lifetime certificate #15642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
reviewed
Jun 23, 2021
| @@ -1,9 +1,12 @@ | |||
| steps: | |||
| - powershell: | | |||
| $shouldSign = $true | |||
| if($env:BUILD_REASON -ne 'Manual') | |||
There was a problem hiding this comment.
Does this mean that builds that are not manual and are not daily will now be signed with the standard Authenticode cert?
There was a problem hiding this comment.
I believe we do not have any builds for this pipeline that are not manual and not daily. The builds we have are:
- Daily build - kicked off automatically so not manual. -> signed
- Manual kicked off for release - so not daily
- Manually kicked off for testing - so not daily
The pipeline also has an option to skip signing using the pipeline schedule time parameter.
There was a problem hiding this comment.
No automated on-push branch build?
There was a problem hiding this comment.
on-push is disabled for the pipeline.
rjmholt
approved these changes
Jun 23, 2021
| @@ -1,9 +1,12 @@ | |||
| steps: | |||
| - powershell: | | |||
| $shouldSign = $true | |||
| if($env:BUILD_REASON -ne 'Manual') | |||
There was a problem hiding this comment.
No automated on-push branch build?
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Enable signing of daily builds with a lifetime certificate. This will allow us to release a signed build but with a certificate which has a small expiry.
MSIX does not support the lifetime cert, hence keep it unchanged.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).