Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cgmanifest.json for generating correct third party notice file #16266

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Oct 18, 2021

PR Summary

Add the cgmanifest file for the modules that are shipped with PowerShell.

PR Context

PR Checklist

@ghost ghost assigned anmenaga Oct 18, 2021
@adityapatwardhan adityapatwardhan added Backport-7.2.x-Consider CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Oct 18, 2021
@daxian-dbw
Copy link
Member

Does this file have to be at the root directory? More and more configuration files are put at the root directory, and I wonder if any of them can be put in sub-directories.

@TravisEz13
Copy link
Member

This file must be in the root folder, but I don't think we need it. Can talk offline because I'm just frustrated with CG right now. 🤦🏼‍♂️

@TravisEz13 TravisEz13 marked this pull request as draft October 18, 2021 20:11
@adityapatwardhan
Copy link
Member Author

I will close this PR as this is not needed.

@adityapatwardhan adityapatwardhan marked this pull request as ready for review October 19, 2021 17:37
@ghost
Copy link

ghost commented Oct 21, 2021

🎉v7.2.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants