Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows build ZIP packaging #16299

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Fix Windows build ZIP packaging #16299

merged 1 commit into from
Oct 27, 2021

Conversation

kondratyev-nv
Copy link
Contributor

PR Summary

Fixes #16261

PR Context

Fix shell for calling PowerShellPackage.ps1 in CI for packaging step.

@ghost ghost assigned anmenaga Oct 23, 2021
@kondratyev-nv
Copy link
Contributor Author

Is there a good way to test this change locally? Or at least before shipping?

@iSazonov iSazonov added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 23, 2021
TravisEz13
TravisEz13 requested changes Oct 23, 2021
View reviewed changes
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saying requesting changes so no one else merges until I verify moving to 7 doesn't break something.

Looks good, we need to run a test build. I started build 219728 (not public, just for me to find it.). Assuming it passes, this should be good to merge at that point. We have a lot of changes to the build system with GA. This might take some time. Ping me periodically if it takes more than a week.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 23, 2021
@TravisEz13 TravisEz13 assigned TravisEz13 and unassigned anmenaga Oct 23, 2021
@TravisEz13
Copy link
Member

Is there a good way to test this change locally? Or at least before shipping?

Short answer, no.

I'm confident it will work, but not 100%. There might be minor changes required is some of scripts, but the environment is quite specialized for releasing Microsoft software and getting a good repro locally would be difficult.

Some of the major gotchas are, json serialization varies between Windows PowerShell and PowerShell 7 and Some variable don't exist in Windows PowerShell.

@TravisEz13 TravisEz13 merged commit d28691f into PowerShell:master Oct 27, 2021
@TravisEz13
Copy link
Member

@kondratyev-nv Thank you for your help!

@TravisEz13
Copy link
Member

We have already branched for the 7.2 release. I'm marking this for Back port consider for each branch we maintain, but I only tested against master.

@kondratyev-nv kondratyev-nv deleted the fix_windows_packaging branch October 27, 2021 18:37
@ghost
Copy link

ghost commented Nov 8, 2021

🎉v7.2.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 8, 2021
Closed
5 tasks
@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@kondratyev-nv @TrapGodBrim
Fix Windows build ZIP packaging (PowerShell#16299)
37c8a1a
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 9, 2022
@kondratyev-nv @adityapatwardhan
Fix Windows build ZIP packaging (PowerShell#16299)
1f2edc6
@TravisEz13
Copy link
Member

/backport to release/v7.0.11

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022 •
edited by unfurl-links bot

Started backporting to release/v7.0.11: https://github.com/PowerShell/PowerShell/actions/runs/2242798277

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions
Copy link
Contributor

@TravisEz13 an error occurred while backporting to release/v7.0.11, please check the run log for details!

Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between release/v7.0.11 and backport/pr-16299-to-release/v7.0.11"}

@TravisEz13
Copy link
Member

Already backported to 7.0: 3b6604f

@TravisEz13 TravisEz13 mentioned this pull request May 24, 2022
Merged
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga anmenaga is a code owner

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

Assignees

@TravisEz13 TravisEz13

Labels
Backport-7.0.x-Done Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extracting Windows build ZIP produces files names with backslashes on MacOS
6 participants
@kondratyev-nv @TravisEz13 @daxian-dbw @anmenaga @adityapatwardhan @iSazonov