-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Get-Error test to not depend on DNS APIs #17471
Update Get-Error test to not depend on DNS APIs #17471
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Error.Tests.ps1
Show resolved
Hide resolved
Merging this as this is blocking #17402 |
🎉 Handy links: |
PR Summary
Update the test to remove the dependency on DNS APIs. If the error information changes, this test should not fail which is just testing the Get-Error formatting.
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).