Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use async streams in Invoke-RestMethod #11095

Merged
merged 9 commits into from
Mar 18, 2020
Merged

Use async streams in Invoke-RestMethod #11095

merged 9 commits into from
Mar 18, 2020

Conversation

iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Nov 17, 2019 •
edited

PR Summary

Fix #4129

  • Use async stream methods in Invoke-RestMethod to save a large file (> 2Gb) to output file as binary
  • Now we can interrupt downloading large file by Ctrl-C
  • Now output file is readable at download time and we can see a size of the file

PR Context

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 18, 2019
@iSazonov iSazonov marked this pull request as ready for review November 18, 2019 07:19
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.1 milestone Nov 23, 2019
@iSazonov
Copy link
Collaborator Author

@SteveL-MSFT @daxian-dbw Have you any comments about the PR or we can merge?

@SteveL-MSFT
Copy link
Member

@iSazonov I trust @adityapatwardhan on this one

daxian-dbw
daxian-dbw reviewed Jan 28, 2020
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking, more comments may be coming

src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/StreamHelper.cs Outdated Show resolved Hide resolved
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jan 29, 2020
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jan 29, 2020
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jan 31, 2020
@iSazonov
Copy link
Collaborator Author

iSazonov commented Feb 4, 2020

@daxian-dbw Please continue your review.

@iSazonov iSazonov merged commit 8ebff6a into PowerShell:master Mar 18, 2020
@iSazonov iSazonov deleted the invoke-rest-pipe branch March 18, 2020 13:40
@ghost
Copy link

ghost commented Mar 26, 2020

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Mar 26, 2020
Closed
@iSazonov iSazonov mentioned this pull request Dec 23, 2020
Closed
@daxian-dbw daxian-dbw mentioned this pull request May 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoshChan PoshChan PoshChan left review comments

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@markekraus markekraus Awaiting requested review from markekraus

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

Assignees

@iSazonov iSazonov

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Milestone
7.1.0-preview.1
Development

Successfully merging this pull request may close these issues.

Invoke-RestMethod fails on very large files
6 participants
@iSazonov @SteveL-MSFT @daxian-dbw @adityapatwardhan @PoshChan @TravisEz13