-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow case insensitive paths for determining PSModulePath
#12192
Allow case insensitive paths for determining PSModulePath
#12192
Conversation
@@ -1250,7 +1250,7 @@ internal static string GetWindowsPowerShellModulePath() | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adityapatwardhan, your last commit had 2 failures in PowerShell-CI-macos
Test-Connection.Ping.Force IPv4 with implicit PingOptions
Expected exactly '127.0.0.1', but got 10.79.0.23.
at <ScriptBlock>, /Users/runner/runners/2.165.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 83
83: $result[0].Address | Should -BeExactly $realAddress
Test-Connection.TraceRoute.TraceRoute works
Expected exactly '127.0.0.1', but got 10.79.0.23.
at <ScriptBlock>, /Users/runner/runners/2.165.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 257
257: $result[0].TargetAddress | Should -BeExactly $realAddress
@PoshChan please retry macos |
@adityapatwardhan, successfully started retry of |
@@ -1250,7 +1250,7 @@ internal static string GetWindowsPowerShellModulePath() | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adityapatwardhan, your last commit had 2 failures in PowerShell-CI-macos
Test-Connection.Ping.Force IPv4 with implicit PingOptions
Expected exactly '127.0.0.1', but got 10.79.0.23.
at <ScriptBlock>, /Users/runner/runners/2.165.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 83
83: $result[0].Address | Should -BeExactly $realAddress
Test-Connection.TraceRoute.TraceRoute works
Expected exactly '10.79.0.59', but got 127.0.0.1.
at <ScriptBlock>, /Users/runner/runners/2.165.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1: line 257
257: $result[0].TargetAddress | Should -BeExactly $realAddress
@PoshChan Please remind me in one hour |
@TravisEz13, I do not understand: Please remind me in one hour Commands available in this repo for you:
|
PSModulePath
PSModulePath
🎉 Handy links: |
🎉 Handy links: |
…ll#12192) * Allow case insensitive comparison of paths for determining PSModulePath * Address codefactor issue
PR Summary
When comparing paths on Windows for determining the PSModulePath, the comparison should be case insensitive.
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.