-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Content Headers to BasicHtmlWebResponseObject and HtmlWebResponseObject #4494
Conversation
@markekraus, |
@markekraus Could you please add tests? |
@iSazonov Tests Added. I wasn't exactly sure what tests to add. There is already significant validation being done on the |
@@ -734,6 +734,24 @@ Describe "Invoke-WebRequest tests" -Tags "Feature" { | |||
|
|||
#endregion SkipHeaderVerification Tests | |||
|
|||
It "Verifies Invoke-WenRequest includes Content headers in Headers property" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo Wen
@iSazonov doh... corrected. |
I agree with @iSazonov . The tests in the issue look like a good starting point. |
@TravisEz13 Thanks. I added the 2 test that make sense. The other tests from the issue won't ever work unless CoreFX drastically changes their approach in |
73d19ed
to
823dd03
Compare
@TravisEz13 @SteveL-MSFT Rebased PR on master to add test fixes from #4512. The new tests are passing. Let me know if I need to make any other changes. |
823dd03
to
75b6f54
Compare
|
||
foreach (var entry in response.Headers) | ||
foreach(var headerCollection in headerCollections) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor point, insert a space after 'foreach' here and 'if' below to match the rest of the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dantraMSFT corrected.
@@ -36,6 +36,12 @@ public partial class WebResponseObject | |||
{ | |||
headers[entry.Key] = entry.Value; | |||
} | |||
if(BaseResponse.Content != null){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor note: place '{' on a new line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dantraMSFT corrected, along with space between if
and (
.
@@ -1070,6 +1070,24 @@ Describe "Invoke-WebRequest tests" -Tags "Feature" { | |||
|
|||
#endregion charset encoding tests | |||
|
|||
It "Verifies Invoke-WebRequest includes Content headers in Headers property" { | |||
$command = "Invoke-WebRequest -Uri 'http://httpbin.org/get'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use HTTPListener here instead of http://httpbin.org/get.
The tests under Context "BasicHtmlWebResponseObject Encoding tests" illustrate using 'test=response&output=$otuput' to pass HTML you want to get in the response. You should consider extending httplistener's 'response' option to allow additional options, such as specifying a content-type header value or other headers to support your testing. let me know if you need any help with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dantraMSFT Thanks. I will work on this and submit more and better tests with your suggestions.
@@ -1070,6 +1070,24 @@ Describe "Invoke-WebRequest tests" -Tags "Feature" { | |||
|
|||
#endregion charset encoding tests | |||
|
|||
It "Verifies Invoke-WebRequest includes Content headers in Headers property" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these two tests need to be either be extended or additional tests added.
1: I don't believe verifying the presence of the header is sufficient; I believe the test should verify the value(s) as well.
2: You added logic to support headers with multiple values so you need to test that case.
@dantraMSFT I have added the requested test changes and httplistener now supports a |
@@ -133,6 +133,14 @@ Function Start-HTTPListener { | |||
$statusCode = $queryItems["statuscode"] | |||
$contentType = $queryItems["contenttype"] | |||
$output = $queryItems["output"] | |||
if ($queryItems['headers']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful to add a comment here that illustrates how the 'headers' value should be formatted; especially since this is the only documentation we have for the listener. :)
At a minimum, show the json structure. Even better would be to show a code sample similar to what you used in your tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dantraMSFT added. comments with examples
LGTM |
@markekraus Can you trigger of feature tests? They seems to have failed last time on Travis CI. |
42f5aca
to
07d7b3d
Compare
@adityapatwardhan feature tag added. |
@adityapatwardhan all tests passed this time. (last time an unrelated test hung accessing a 3rd party website). |
LGTM. Thanks for great work! |
Fixes #4467
System.Net.Http.HttpResponseMessage
has split the Content headers from the Response headers. This split appears to be intentional and permanent. This split results in theContent-Type
andContent-Length
headers to be missing from theWebResponseObject.Headers
dictionary and from theRawContent
property ofBasicHtmlWebResponseObject
andHtmlWebResponseObject
.This adds the Content headers back to those locations to make it similar to 5.1.
This also adds support to
RawContent
for multiple response headers with the same field name.System.Net.Http.Headers.HttpContentHeaders
andSystem.Net.Http.Headers.HttpResponseHeaders
implement values as arrays.