Only push to NuGet for Full Build (cron) #4517
Conversation
tools/travis.ps1
Outdated
| @@ -181,7 +181,11 @@ else | |||
| $packages += Start-PSPackage @packageParams -Type AppImage | |||
| foreach($package in $packages) | |||
| { | |||
| if($env:NUGET_KEY -and $env:NUGET_URL -and [system.io.path]::GetExtension($package) -ieq '.nupkg') | |||
| # Publish the packages to the nuget feed if: | |||
| # 1 - It's a fullBuild (allready checked, for not a PR) | |||
There was a problem hiding this comment.
Typo in allready -> already
tools/travis.ps1
Outdated
| # 1 - It's a fullBuild (allready checked, for not a PR) | ||
| # 2 - We have the info to publish (NUGET_KEY and NUGET_URL) | ||
| # 3 - it's a nupkg file | ||
| if($isFullBuild -and $env:NUGET_KEY -and $env:NUGET_URL -and [system.io.path]::GetExtension($package) -ieq '.nupkg') |
There was a problem hiding this comment.
This also published if it is [Feature] run?
There was a problem hiding this comment.
Only if we merge a feature... that is equivalent to a daily build, I'm fine with it. If it's a PR, it won't publish. And if you squash merge, you will likely, remove the [Feature] from the commit message.
There was a problem hiding this comment.
actually, a true merge would change the description of the last commit message too. Only merging to master using the rebase option would have this possible effect.
|
The badge issue is being fixed in #4536 |
tools/travis.ps1
Outdated
| # 1 - It's a fullBuild (already checked, for not a PR) | ||
| # 2 - We have the info to publish (NUGET_KEY and NUGET_URL) | ||
| # 3 - it's a nupkg file | ||
| if($isFullBuild -and $env:NUGET_KEY -and $env:NUGET_URL -and [system.io.path]::GetExtension($package) -ieq '.nupkg') |
There was a problem hiding this comment.
After merging a PR to master, if the commit message happen to have [Feature] tag, we will publish the nuget package as well. Is that desired? Maybe we should use $isDailyBuild instead.
8afb947
to
b4bcbf1
Compare
Currently, every merge is also publishing.