New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenCover and Code coverage improvements #4550

Merged

daxian-dbw merged 1 commit into PowerShell:master from adityapatwardhan:CCAutomation

Aug 14, 2017

Member

adityapatwardhan commented Aug 11, 2017

Delete the code coverage output file before the run instead of after the run. So we can remote desktop and see the last runs results,
Use -noprofile for powershell.exe so that we restrict the testing the PSv6.


          Opencover and Code coverage improvements

075bbf3

adityapatwardhan requested a review from JamesWTruher

August 11, 2017 00:20

msftclas added the cla-not-required label

JamesWTruher approved these changes

View reviewed changes

test/tools/OpenCover/OpenCover.psm1

                       "-hideskipped:all",
                       "-mergeoutput",
                       "-filter:`"+[*]* -[Microsoft.PowerShell.PSReadLine]*`"",
-                      "-targetargs:`"-EncodedCommand $base64targetArgs`""
+                      "-targetargs:`"-NoProfile -EncodedCommand $base64targetArgs`""

Member

JamesWTruher Aug 11, 2017

this is fine, and another possible parameter to use is -noninteractive which will keep PSReadLine from being loaded.

daxian-dbw self-assigned this

daxian-dbw merged commit b953ab1 into PowerShell:master

adityapatwardhan deleted the CCAutomation branch

August 17, 2017 00:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment