Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Mark Multiple Response Header Test Pending #4640

Merged

Conversation

markekraus
Copy link
Contributor

The Verifies Invoke-WebRequest Supports Multiple response headers with same name test from #4494 is failing on Linux and macOS due to an implementation difference of HttpListener on Linux and macOS where multiple response headers are concatenated instead of sent as separate headers.

In Windows:

HTTP/1.1 200 OK
Content-Length: 2
Content-Type: text/plain
Server: Microsoft-HTTPAPI/2.0
X-Fake-Header: testvalue01
X-Fake-Header: testvalue02
Date: Tue, 22 Aug 2017 09:49:37 GMT

In Linux/macOS:

HTTP/1.1 200 OK
X-Fake-Header: testvalue01, testvalue02
Server: Microsoft-NetCore/2.0
Date: Tue, 22 Aug 2017 09:18:18 GMT
Content-Type: text/plain
Content-Length: 2

This is not a failure of the test but an issue with the current method used for serving test content with HttpListener.

Issue #4639 has been created to track creating a cross-platform multiple header response solution for this test. In the mean time, mark this test as pending to prevent nightly failures.

@msftclas
Copy link

@markekraus,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@anmenaga
Copy link
Contributor

@TravisEz13 @SteveL-MSFT This needs to be merged asap as it fixes a failure in night test pass.

@TravisEz13
Copy link
Member

merging before 24 hours, because this fixes a test failure. @anmenaga Please in the future, be clear if you reviewed the change.

@TravisEz13 TravisEz13 merged commit 5941b89 into PowerShell:master Aug 22, 2017
@markekraus markekraus deleted the MultiResponseHeadertestPending branch August 25, 2017 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants