Rename $IsOSX to $IsMacOS #4757
Conversation
|
I don't see changes to |
|
@daxian-dbw ok, looks like VSCode cached exclusion list and I previously excluded build.psm1, will fix. looks like .md files were excluded as well. |
5e51de6
to
a59c391
Compare
|
Apple Inc. uses |
|
@iSazonov we had that discussion in the issue, the consensus is that $IsMacOS is preferred over $IsmacOS for readability and other languages (like Java) use isMacOS, so it's already somewhat common. |
| @@ -42,7 +42,7 @@ function Set-DailyBuildBadge | |||
| $storageAccountKey = $Env:TestResultAccountKey | |||
|
|
|||
| # this is the url referenced in README.MD which displays the badge | |||
| $platform = if ( $IsOSX ) { "OSX" } else { "Linux" } | |||
| $platform = if ( $IsLinux ) { "Linux" } else { "OSX" } | |||
There was a problem hiding this comment.
Minor comment - maybe replace "OSX" too?
There was a problem hiding this comment.
The file stored in Azure for the badge has OSX in the filename. I'm fine leaving that one.
|
Should this run through the CI with [feature] to ensure none of the feature tests broke with the change? |
|
@markekraus good point, I'll resubmit |
a59c391
to
54a4786
Compare
|
AppVeyor failure is due to the current issue causing nightly to fail and @dantraMSFT is looking into it |
|
Yes, the failure is due to #4763. You can ignore it. |
54a4786
to
3331654
Compare
|
Rebased to pick up fix |
PS-Committee decided we should be consistent with our naming and conform to Apple's use of macOS instead of OSX, however, for readability and consistently we are staying with Pascal casing.
Also renamed instances of variations of
OSXtomacOSfor consistency in comments/text (separate commit to make it easier to review)Fix #4700