Remove PerformWSManPluginReportCompletion from pwrshplugin.dll #5498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly used for WSManPluginReportCompletion
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 29, 2017
…Shell#5498) This resolves issue PowerShell#5391, which is tagged with 6.0.0-GA, therefore this should help with getting pwsh out of the door in January. It removes PerformWSManPluginReportCompletion as stated in the issue and its associated class member g_pPluginContext, which is now unused as well. The best reviewer is probably @mirichmo , who raised the initial issue with very helpful descriptions or @dantraMSFT who is currently assigned to the issue.
Merged
TravisEz13
pushed a commit
that referenced
this pull request
Nov 29, 2017
This resolves issue #5391, which is tagged with 6.0.0-GA, therefore this should help with getting pwsh out of the door in January. It removes PerformWSManPluginReportCompletion as stated in the issue and its associated class member g_pPluginContext, which is now unused as well. The best reviewer is probably @mirichmo , who raised the initial issue with very helpful descriptions or @dantraMSFT who is currently assigned to the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #5391, which is tagged with
6.0.0-GA, therefore this should help with getting pwsh out of the door in January.It removes
PerformWSManPluginReportCompletionas stated in the issue and its associated class memberg_pPluginContext, which is now unused as well.The best reviewer is probably @mirichmo , who raised the initial issue with very helpful descriptions or @dantraMSFT who is currently assigned to the issue.