References to RunspaceConfiguration still present #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PI documentation Updated the 2 unit tests accordingly with Runspaceconfiguration removal PowerShell#4942
|
|
SteveL-MSFT
approved these changes
Nov 29, 2017
|
Indeed. I do not think you compile them ... otherwise they should fail for a couple of weeks. |
|
@Bhaal22 I think the changes to the test are correct, separate from this PR, someone should understand if that test code is still relevant if so, get it running. |
|
@SteveL-MSFT do you mean you would like to have 2 PRs? |
|
@Bhaal22 no, I think it's fine to have these changes as part of a single PR. I'm suggesting that investigating the utility of that test code is separate from this PR. |
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 30, 2017
Merged
TravisEz13
pushed a commit
that referenced
this pull request
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RunspaceConfiguration still mentionned in RunspacePoolInternal ctor API documentation
Removed 2 obsolete test files
Those 2 files should even not compile.
#4942