-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor refactoring of the release build scripts #5632
Conversation
tools/releaseBuild/build.json
Outdated
@@ -69,7 +69,7 @@ | |||
], | |||
"DockerImageName": "ps-winsrvcore", | |||
"BinaryBucket": "symbols", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we change the containerfolder in the other PR, we need to change the binarybucker where it equals symbols to results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the other PR has been updated. I also changed BinaryBucket
to results
for the -symbols
entries.
@TravisEz13 Can you have another look? |
* Update release build * Minor refactoring of the build script
* Update release build * Minor refactoring of the build script
PR Checklist
Note: Please mark anything not applicable to this PR
NA
.win-arm
andwin-arm64
packages needs to.[feature]
if the change is significant or affectes feature testsPR Summary
Some name changes, comment updates, and random fixes.
This depends on PowerShell/PSRelease#28 to be merged.