Update PowerShell to build with .NET Core 2.0.4 #5677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
reviewed
Dec 12, 2017
| @@ -94,7 +94,7 @@ | |||
| <Copyright>(c) Microsoft Corporation. All rights reserved.</Copyright> | |||
|
|
|||
| <TargetFramework>netcoreapp2.0</TargetFramework> | |||
| <RuntimeFrameworkVersion>2.0.4-servicing-25831-01</RuntimeFrameworkVersion> | |||
There was a problem hiding this comment.
should we update the appveyor yml to flush the cache?
TravisEz13
approved these changes
Dec 12, 2017
|
Investigating the xUnit test failures. |
SteveL-MSFT
approved these changes
Dec 12, 2017
|
Don't forget to update - https://github.com/PowerShell/PowerShell/blob/master/global.json |
|
@rkeithhill That is the SDK version. SDK version is not changed in this PR and we are still using 2.0.2. This PR only changes the version of .NET Core Runtime Framework that powershell targets. |
|
I'm beginning to understand @vors rant on Twitter about .NET Core versioning. :-) |
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 13, 2017
TravisEz13
pushed a commit
that referenced
this pull request
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Close #5428
Update PowerShell to build with .NET Core 2.0.4. (turn out to be a simple change 馃槃)
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.