Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pull request Template Typo and Markdown Linting Error #5807

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

markekraus
Copy link
Contributor

@markekraus markekraus commented Jan 6, 2018

PR Summary

  • affectes -> affects
  • Fix linting issue with comment

PR Checklist

Note: Please mark anything not applicable to this PR NA.

Copy link
Contributor

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the PR title has a typo: Markdonw -> Markdown

@markekraus markekraus changed the title Fix Pull request Template Typo and Markdonw Linting Error Fix Pull request Template Typo and Markdown Linting Error Jan 6, 2018
@markekraus
Copy link
Contributor Author

@bergmeister lol.. thanks.. corrected.

@daxian-dbw daxian-dbw merged commit 1b3d1ee into PowerShell:master Jan 8, 2018
@bergmeister
Copy link
Contributor

bergmeister commented Jan 8, 2018

@markekraus It gets even better, the merge commit contains the original typo in the commit message (I always thought it was the PR title that forms the basis of the squash commit but I seem to be wrong). Nevermind, no one is going to notice/care.

@TravisEz13 TravisEz13 added this to the 6.0.0-GA milestone Jan 9, 2018
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Jan 9, 2018
@TravisEz13 TravisEz13 mentioned this pull request Jan 9, 2018
@markekraus markekraus deleted the PRTemplateSpellingFix branch January 19, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants