Change to Read/Write Neutral Progress Messages for Web Cmdlets WriteToStream() #5078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
reviewed
Oct 10, 2017
| @@ -184,13 +184,13 @@ | |||
| <value>Unable to retrieve certificates because the thumbprint is not valid. Verify the thumbprint and retry. </value> | |||
| </data> | |||
| <data name="WriteRequestComplete" xml:space="preserve"> | |||
| <value>Writing web request completed. (Number of bytes remaining: {0})</value> | |||
| <value>Web request processing completed. (Number of bytes remaining: {0})</value> | |||
There was a problem hiding this comment.
Maybe:
<value>Web request completed. (Number of bytes processed: {0})</value>
| </data> | ||
| <data name="WriteRequestProgressStatus" xml:space="preserve"> | ||
| <value>Writing request stream... (Number of bytes written: {0})</value> | ||
| <value>Processing... (Number of bytes processed: {0})</value> |
There was a problem hiding this comment.
I'd remove repeating "Processing" - "processed".
Maybe:
<value>Number of bytes processed: {0}</value>
iSazonov
approved these changes
Oct 10, 2017
SteveL-MSFT
requested changes
Oct 10, 2017
| @@ -184,13 +184,13 @@ | |||
| <value>Unable to retrieve certificates because the thumbprint is not valid. Verify the thumbprint and retry. </value> | |||
| </data> | |||
| <data name="WriteRequestComplete" xml:space="preserve"> | |||
| <value>Writing web request completed. (Number of bytes remaining: {0})</value> | |||
| <value>Web request completed. (Number of bytes processed: {0})</value> | |||
There was a problem hiding this comment.
Is the original "remaining" correct? Meaning that it should be "Number of bytes to process"?
There was a problem hiding this comment.
I think it was wrong all along. This string is the message that is sent last when the stream has completed.
in 5.1:
$Job = Start-Job -ScriptBlock {
Invoke-WebRequest https://dist.nuget.org/win-x86-commandline/latest/nuget.exe -outfile $env:temp\nuget.exe
} | Wait-Job
$progress = $Job.ChildJobs[0].Progress.ReadAll()
$progress[-2].StatusDescription
$progress[-1].StatusDescriptionresult:
Writing request stream... (Number of bytes written: 5010552)
Writing web request completed. (Number of bytes remaining: 5010552)
There was a problem hiding this comment.
Ok, your change looks good then. Thanks!
SteveL-MSFT
approved these changes
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3677
The progress message can be a bit confusing depending on the context in which
WriteToStream()is called. This PR changes the wording to be Read/Write neutral favoring "Processing" instead.