Add Remove-Alias Command #5143

PowershellNinja · 2017-10-17T16:07:04Z

Hi Powershell Team!

My boss visited a particular Powershell session at MS Ignite 2017 where a particular person said he would like a Pull Request containing the Remove-Alias Cmdlet.

We thought this would be a good point to start contributing to Powershell!

The PR contains the Remove-Alias Cmdlet and some tests for it (and a reference in the .psd1).
As this is my first contribution to Powershell I am looking forward to all thoughts, comments and suggestions, please tell me if there is anything I need to improve.

Regards,
Raphael

….psd1.

iSazonov

@PowershellNinja Thanks for your contribution!

Alternative is Remove-Item alias:\AliasName

@SteveL-MSFT Can we approve the new cmdlet?

iSazonov · 2017-10-18T06:17:53Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

@@ -0,0 +1,117 @@
+/********************************************************************++
+Copyright (c) Microsoft Corporation.  All rights reserved.
+--********************************************************************/


I believe we should remove the copyright.

iSazonov · 2017-10-18T06:18:52Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+namespace Microsoft.PowerShell.Commands
+{
+    /// <summary>
+    /// The implementation of the "remove-alias" cmdlet


Please use right case and dot:

/// The implementation of the "Remove-Alias" cmdlet.

iSazonov · 2017-10-18T06:20:29Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+    /// The implementation of the "remove-alias" cmdlet
+    /// </summary>
+    ///
+    [Cmdlet(VerbsCommon.Remove, "Alias", DefaultParameterSetName = "Default", HelpUri = "")]


@daxian-dbw @HemantMahawar @SteveL-MSFT We need new HelpUri.

Issue opened: #15625

iSazonov · 2017-10-18T06:21:03Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+        /// The Name parameter for the command
+        /// </summary>
+        ///
+        [Parameter(Position = 0, Mandatory = true, ValueFromPipelineByPropertyName = true)]


I think we should add ValueFromPipeline too.

iSazonov · 2017-10-18T06:21:26Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+         #region Parameters
+
+        /// <summary>
+        /// The Name parameter for the command


Please add dot.

iSazonov · 2017-10-18T06:32:06Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+        #endregion Command code
+
+    } // class GetAliasCommand
+}//Microsoft.PowerShell.Commands


Formatting.
I'd remove such comments at all - VS manipulates blocks very well.

iSazonov · 2017-10-18T06:36:03Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Remove-Alias.Tests.ps1

+
+#Store ErrorActionPreference Value
+$storedEA = $ErrorActionPreference
+$ErrorActionPreference = "Stop"


Please remove and use -ErrorAction Stop` explicitly in a cmdlet.

iSazonov · 2017-10-18T06:37:01Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Remove-Alias.Tests.ps1

+        }
+        catch{
+            $_.FullyQualifiedErrorId | Should Be 'ItemNotFoundException,Microsoft.PowerShell.Commands.GetAliasCommand'
+        }


Please use the pattern:

{ ... } | ShouldBeErrorId 'ItemNotFoundException,Microsoft.PowerShell.Commands.GetAliasCommand'

Use -ErrorAction Stop.

Below too.

iSazonov · 2017-10-18T06:39:37Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Remove-Alias.Tests.ps1

+$ErrorActionPreference = "Stop"
+Describe "Remove-Alias" -Tags "CI" {
+
+    It "Remove-Alias Should Remove Non-ReadOnly Alias"{


Space skipped.
And please use normal case for normal words:
"Remove-Alias should remove a non-readonly alias" {

Below too.

iSazonov · 2017-10-18T06:40:41Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Remove-Alias.Tests.ps1

+    }
+}
+#Reset ErrorActionPreference to old Value
+$ErrorActionPreference = $storedEA


Please remove $ErrorActionPreference - see my comment above.
Please add new line at EOF.

SteveL-MSFT · 2017-10-18T20:22:13Z

I don't think adding Remove-Alias should be an issue, but I'll bring it up today at the committee meeting.

joeyaiello · 2017-10-18T22:00:27Z

I'm good with it!

SteveL-MSFT · 2017-10-18T22:02:50Z

@PowerShell/powershell-committee no concerns from PS-Committee on the addition of this cmdlet. Thanks for the contribution!

…rence variable. Remove unnecessary Get-Alias calls. Switch Force parameter to auto property. Add ValueFromPipeline to Remove-Alias Name parameter.

PowershellNinja · 2017-10-20T11:06:09Z

@iSazonov Wow, thanks for all your feedback! I tried to incorporate it all in the last commit. Is there anything else I can / should do?

iSazonov

Please add "Remove-Alias"

in https://github.com/PowerShell/PowerShell/blob/master/src/Modules/Unix/Microsoft.PowerShell.Utility/Microsoft.PowerShell.Utility.psd1 to export the cmdlet on Unix.
in https://github.com/PowerShell/PowerShell/blob/master/test/powershell/engine/Basic/DefaultCommands.Tests.ps1 to pass tests

iSazonov · 2017-10-20T11:22:57Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+         #region Parameters
+
+        /// <summary>
+        /// The Name parameter for the command.


Maybe "The alias name to remove."

iSazonov · 2017-10-20T11:39:18Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+                    existingAlias = SessionState.Internal.GetAliasAtScope(Name, Scope);
+                }
+            }
+            catch (SessionStateException sessionStateException)


The exception is already our PowerShell exception so please remove the try-catch and WriteError.

iSazonov · 2017-10-20T11:41:08Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+                try{
+                    SessionState.Internal.RemoveAlias(Name, Force);
+                }
+                catch (SessionStateException sessionStateException)


The same please remove the try-catch.

iSazonov · 2017-10-20T11:50:48Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+            else
+            {
+                ItemNotFoundException notAliasFound = new ItemNotFoundException(StringUtil.Format(AliasCommandStrings.NoAliasFound, "name", Name));
+                ErrorRecord error = new ErrorRecord(notAliasFound, "ItemNotFoundException",ErrorCategory.ObjectNotFound, Name);


Please add WriteError(error);
And please add new test for the case.

iSazonov · 2017-10-20T12:02:15Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+        /// <summary>
+        /// The Name parameter for the command.
+        /// </summary>
+        ///


Please remove the extra line in all file.

…-Alias to approved Commands test. Remove Try/Catch for SessionstateException. Add WriteError for aliasnotfound exception.

PowershellNinja · 2017-10-22T14:06:52Z

Thanks for the additional suggestions, implemented them all. Are the empty lines between the tests and between the #region and parameter statements ok or should I remove them too?

iSazonov

@PowershellNinja Thanks for your contribution! We are near to merge.

iSazonov · 2017-10-22T17:52:48Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Remove-Alias.Tests.ps1

+    }
+
+    It "Remove-Alias should throw if alias does not exist"{
+        {            


I think we should protect themselves and add Get-Alias -Name "foo" | Should BeNullorEmpty before trying to remove.

Do you mean as a separate tests before the "Remove-Alias should throw if alias does not exist" test or just like this:

It "Remove-Alias should throw if alias does not exist"{ { Get-Alias -Name "foo" | Should BeNullorEmpty Remove-Alias -Name "foo" -ErrorAction Stop } | ShouldBeErrorId 'ItemNotFoundException,Microsoft.PowerShell.Commands.RemoveAliasCommand' }

Yes. Only with -ErrorAction SilentlyContinue
Get-Alias -Name "foo" -ErrorAction SilentlyContinue | Should BeNullorEmpty

iSazonov · 2017-10-22T17:52:56Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Remove-Alias.Tests.ps1

+        {
+            Set-Alias -Name "foo" -Value "bar"
+            Remove-Alias -Name "foo"
+            Get-Alias -Name "foo" -ErrorAction Stop


I think we should keep a consistency and add -ErrorAction Stop to previous two lines - that will exclude false positives.
Please add this in tests below.

iSazonov · 2017-10-22T17:57:18Z

Are the empty lines between the tests and between the #region and parameter statements ok or should I remove them too?

It is ok for new files.
Main rule is - we must follow the pattern of the surrounding code to keep readability.

…sts for consistency. Add Should BeNullOrEmpty to "should throw if alias does not exist" test to verify that foo alias really is not there before removing it.

iSazonov · 2017-10-26T05:44:31Z

@adityapatwardhan @anmenaga Please review the PR.

adityapatwardhan · 2017-10-26T17:20:05Z

@PowershellNinja restarted the macOS build for Travis-CI.

adityapatwardhan · 2017-10-26T17:31:01Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+    /// </summary>
+    ///
+    [Cmdlet(VerbsCommon.Remove, "Alias", DefaultParameterSetName = "Default", HelpUri = "")]
+    public class RemoveAliasCommand : PSCmdlet


Please add an alias for Remove-Alias at : https://github.com/PowerShell/PowerShell/blob/master/src/System.Management.Automation/engine/InitialSessionState.cs#L4656
I recommend ral so we are consistent with gal,sal and nal

adityapatwardhan · 2017-10-26T17:31:45Z

test/powershell/engine/Basic/DefaultCommands.Tests.ps1

@@ -363,6 +363,7 @@ Describe "Verify approved aliases list" -Tags "CI" {
 "Cmdlet", "Register-ObjectEvent",                               ,                     $($FullCLR -or $CoreWindows -or $CoreUnix)
 "Cmdlet", "Register-PSSessionConfiguration",                    ,                     $($FullCLR -or $CoreWindows -or $CoreUnix)
 "Cmdlet", "Register-WmiEvent",                                  ,                     $($FullCLR                               )
+"Cmdlet", "Remove-Alias",                                       ,                     $($FullCLR -or $CoreWindows -or $CoreUnix)


Similarly add an entry here for ral

Please remove $FullCLR.

adityapatwardhan · 2017-10-26T17:39:15Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+        /// The alias name to remove.
+        /// </summary>        
+        [Parameter(Position = 0, Mandatory = true, ValueFromPipeline = true, ValueFromPipelineByPropertyName = true)]
+        public string Name { get; set; }


This should be a string[]. All the Remove* cmdlets that have a Name parameter support having a array for names.

adityapatwardhan · 2017-10-26T17:39:54Z

src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs

+        /// </summary>        
+        protected override void ProcessRecord()
+        {
+            AliasInfo existingAlias = null;           


The logic here should be updated to remove multiple aliases when the parameter for Name changes to string[].

adityapatwardhan · 2017-10-26T17:45:42Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Remove-Alias.Tests.ps1

+Describe "Remove-Alias" -Tags "CI" {
+    It "Remove-Alias should remove a non-readonly alias"{
+        {
+            Set-Alias -Name "foo" -Value "bar" -ErrorAction Stop


Please update the strings so that they use better names than foo and bar.

adityapatwardhan · 2017-10-26T17:48:05Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Remove-Alias.Tests.ps1

+            Set-Alias -Name "foo" -Value "bar" -ErrorAction Stop
+            Remove-Alias -Name "foo" -Scope 99999 -ErrorAction Stop
+        } | ShouldBeErrorId "ArgumentOutOfRange,Microsoft.PowerShell.Commands.RemoveAliasCommand"
+    }


Add a case for ral

@adityapatwardhan We have a test set for aliases in separate file and shouldn't test aliases here.

Correct. Please add tests here: https://github.com/PowerShell/PowerShell/tree/master/test/powershell/Modules/Microsoft.PowerShell.Utility

There are test files for Get-Alias and Set-Alias over there.

@adityapatwardhan @iSazonov sorry, I saw this conversation just now, I'll move the test with the alias, but I'm not sure I understood where I should put them. Currently I have the test together with the other tests unter https://github.com/PowerShell/PowerShell/tree/master/test/powershell/Modules/Microsoft.PowerShell.Utility in a separate file called "Remove-Alias.Tests.ps1". Should I move the whole file or just the test testing for the ral alias?

@PowershellNinja You are right. Changes in DefaultCommands.Tests.ps1 should have you covered to testing alias. Sorry for the confusion.

@adityapatwardhan absolutely no problem, I just was not sure if I have to put the test elsewhere. I removed it in the recent commit.

…rocess Logic to work with String Array. Added Alias named "ral". Added test case for Alias "ral". Added "ral" Alias to list of approved Aliases. Replaced foo and bar values in all tests with better names.

…e on the Remove-Alias Cmdlet.

iSazonov · 2017-10-31T04:31:26Z

@PowershellNinja Please resolve merge conflict.

PowershellNinja · 2017-10-31T09:42:27Z

@iSazonov The conflict seems to be in DefaultCommands.Tests.ps1 and is caused by my addition of the Test for the "ral" alias. Do I have to remove it there now that I removed the Alias itself from "\src\System.Management.Automation\engine\InitialSessionState.cs"?
This is also the cause of the CI failing, the "ral" alias does not seem to work by just adding the [Alias()] attribute on the Cmdlet, do I need to add something else there?

iSazonov · 2017-10-31T10:36:10Z

@PowershellNinja I did this.

If you plan work with Git - please learn topics about resolving conflicts in Git.
Here we'll always try to help you.

PowershellNinja · 2017-10-31T10:47:10Z

@iSazonov Sorry, I think I did not clearly formulate that, thanks for taking care of the conflict. My question was not about the merge conflict, but about the fact that when I just have the "ral" alias added using the [Alias()] attribute on the Cmdlet, the alias does not seem to exist/work. Do you have any Idea why this might be?

iSazonov · 2017-10-31T10:48:22Z

@adityapatwardhan Can we merge without waiting CI MacOS?

iSazonov · 2017-10-31T12:35:28Z

@PowershellNinja Tests show that all works well.
When you tried to add a duplicate alias I believe the session initialization failed - both are in the same method, you got a broken environment.

PowershellNinja · 2017-10-31T18:04:09Z

@iSazonov Ah I see, that may explain it. I retested with only one alias and all worked as expected.

adityapatwardhan · 2017-10-31T22:38:21Z

@PowershellNinja I restarted the macOS build and it passes now.

JamesWTruher

none of my comments are blocking

JamesWTruher · 2017-11-01T00:08:33Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Remove-Alias.Tests.ps1

@@ -0,0 +1,58 @@
+Describe "Remove-Alias" -Tags "CI" {


one of the things that could happen on dev boxes is that an alias tral could exist which could cause some test failures. Since it doesn't matter, should this be something more unlikely to have a collision (say a generated guid)?

@PowershellNinja Could you please address the request?
Sample:

Describe "Remove-Alias" -Tags "CI" { BeforeAll { $testAliasName = (New-Guid).Guid } ...

JamesWTruher · 2017-11-01T00:12:00Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Remove-Alias.Tests.ps1

+        } | ShouldBeErrorId 'ItemNotFoundException,Microsoft.PowerShell.Commands.GetAliasCommand'
+    }
+
+    It "Remove-Alias should throw if alias does not exist"{


i assume that this is a non-terminating error - should there be a test for that? Something like:

Remove-Alias -Name "tral" -ErrorVariable RemoveAliasError 2>$null $RemoveAliasError.FullyQualifiedErrorId | ShouldBe "ItemNotFoundException,Microsoft.PowerShell.Commands.RemoveAliasCommand"

We have tons of such "incorrect" tests. I think we should refactor them all in time or after resolving #4781

JamesWTruher · 2017-11-01T00:16:15Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Remove-Alias.Tests.ps1

+        }
+    }
+
+    It "Remove-Alias should throw on out-of-range scope"{


it might be worth adding some tests with explicit scope probes. Say create an alias in scope 3, then remove it without a scope, it should still be in scope 3, etc. I don't think we have many tests which explicitly loot at testing our scopes, so it would be a welcome change

I see that CodeCov reports internal void RemoveAlias falls under tests. Formally we don't get increasing code coverage with the change.
Although I found up to 34 test files with "scope" word in the repo the SessionStateAliasAPIs.cs code coverage is only 68%. I've view these tests before, some look like tricky so I didn't venture to make improvements. I think we need to open new tracking Issue if we want have better scope tests.

iSazonov · 2017-11-02T13:13:04Z

@PowershellNinja Please address the comment about tests and I'll merge.

…void collisions

PowershellNinja · 2017-11-03T06:47:34Z

@iSazonov @JamesWTruher I implemented the suggestion about the tests in the latest commit

iSazonov · 2017-11-03T08:09:23Z

@PowershellNinja Many thanks for your contribution! Welcome back with new PRs!

PowershellNinja · 2017-11-03T13:20:45Z

@iSazonov Awesome! Thanks all reviewers for your feedback and suggestions! I am looking forward to working on Powershell again in the future! Von meinem iPhone gesendet Am 03.11.2017 um 09:09 schrieb Ilya <notifications@github.com<mailto:notifications@github.com>>: @PowershellNinja<https://github.com/powershellninja> Many thanks for your contribution! Welcome back with new PRs! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#5143 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMGT2FQ-OwxyeUqb3SQeSrT9oivob6Xzks5syspAgaJpZM4P8bNW>.

jpsnover

You need to remove the ValueFromPipeline for the NAME param or this won't work properly.
You can see that if you do
PS> gal E* |Select Name
PS> gal E* |Select Name |Remove-aLias

jpsnover · 2017-11-06T20:45:05Z

We should probably have a PSAnalyzer rule which warns people away from having ValueFromPipeline=TRUE on a STRING. This is almost always the wrong thing to do.

iSazonov · 2017-11-08T07:07:18Z

Do we expect the behavior?

gal E* |Select Name |Remove-aLias -Force

PowershellNinja · 2017-11-08T17:29:53Z

@iSazonov I was able to reproduce this, as long as you use -Force, it removes the Aliases, without -Force it throws at the first removal because "ebp" is Read-Only:

gal E* | Select Name
Name
----
ebp
echo
epal
epcsv
erase
etsn
exsn

gal E* | Select Name | Remove-Alias
Remove-Alias : Alias was not removed because alias ebp is constant or read-only.

gal E* | Select Name | Remove-Alias -Force
gal E* | Select Name
*Nothing Here*

iSazonov · 2017-11-08T17:48:37Z

We can easily fix this with try-catch and writing non-terminating error.

Add Remove-Alias Command. Add Remove-Alias Test. Add Remove-Alias to …

4a2a5a7

….psd1.

PowershellNinja requested review from dantraMSFT, JamesWTruher and PaulHigin as code owners October 17, 2017 16:07

PowershellNinja force-pushed the master branch from 02d9721 to 4a2a5a7 Compare October 17, 2017 16:10

iSazonov reviewed Oct 18, 2017

View reviewed changes

SteveL-MSFT added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Oct 18, 2017

SteveL-MSFT removed the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Oct 18, 2017

SteveL-MSFT added the Committee-Reviewed PS-Committee has reviewed this and made a decision label Oct 18, 2017

daxian-dbw assigned iSazonov Oct 20, 2017

daxian-dbw requested review from adityapatwardhan and anmenaga October 20, 2017 00:39

Fix code-formatting. Fix ErrorAction on Remove-Alias instead of prefe…

a8f7752

…rence variable. Remove unnecessary Get-Alias calls. Switch Force parameter to auto property. Add ValueFromPipeline to Remove-Alias Name parameter.

iSazonov reviewed Oct 20, 2017

View reviewed changes

Remove empty lines. Add Remove-Alias to Unix Module .psd1. Add Remove…

234c436

…-Alias to approved Commands test. Remove Try/Catch for SessionstateException. Add WriteError for aliasnotfound exception.

iSazonov reviewed Oct 22, 2017

View reviewed changes

SteveL-MSFT added the Documentation Needed in this repo Documentation is needed in this repo label Oct 22, 2017

Add ErrorAction Stop to all Get-Alias and Set-Alias Cmdlets in all te…

79f396d

…sts for consistency. Add Should BeNullOrEmpty to "should throw if alias does not exist" test to verify that foo alias really is not there before removing it.

iSazonov approved these changes Oct 26, 2017

View reviewed changes

adityapatwardhan requested changes Oct 26, 2017

View reviewed changes

Changed Remove-Alias parameter Name to String-Array. Changed Cmdlet P…

f06f593

…rocess Logic to work with String Array. Added Alias named "ral". Added test case for Alias "ral". Added "ral" Alias to list of approved Aliases. Replaced foo and bar values in all tests with better names.

PowershellNinja requested a review from BrucePay as a code owner October 26, 2017 20:05

Add Alias "ral" to Remove-Alias Cmdlet.

88fd895

adityapatwardhan approved these changes Oct 27, 2017

View reviewed changes

Remove "ral" alias as this is handled by using the [Alias()] attribut…

7ad77ed

…e on the Remove-Alias Cmdlet.

Merge branch 'master' into master

f1c67a9

JamesWTruher reviewed Nov 1, 2017

View reviewed changes

Replace alias names used in Remove-Alias Cmdlet tests with GUIDs to a…

33230b6

…void collisions

iSazonov approved these changes Nov 3, 2017

View reviewed changes

iSazonov merged commit c9f83fe into PowerShell:master Nov 3, 2017

jpsnover reviewed Nov 6, 2017

View reviewed changes

joeyaiello mentioned this pull request Oct 15, 2018

Docs needed for 'Add Remove-Alias Command' MicrosoftDocs/PowerShell-Docs#3073

Closed

joeyaiello removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018

xtqqczze mentioned this pull request Jun 21, 2021

Add missing Remove-Alias HelpUri #15625

Closed

rjmholt added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 21, 2021

Add Remove-Alias Command #5143

Add Remove-Alias Command #5143

Conversation

PowershellNinja commented Oct 17, 2017

iSazonov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SteveL-MSFT commented Oct 18, 2017

joeyaiello commented Oct 18, 2017

SteveL-MSFT commented Oct 18, 2017

PowershellNinja commented Oct 20, 2017

iSazonov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PowershellNinja commented Oct 22, 2017

iSazonov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PowershellNinja Oct 24, 2017 • edited

Choose a reason for hiding this comment

iSazonov Oct 25, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iSazonov commented Oct 22, 2017

iSazonov commented Oct 26, 2017

adityapatwardhan commented Oct 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iSazonov commented Oct 31, 2017

PowershellNinja commented Oct 31, 2017

iSazonov commented Oct 31, 2017

PowershellNinja commented Oct 31, 2017 • edited

iSazonov commented Oct 31, 2017

iSazonov commented Oct 31, 2017

PowershellNinja commented Oct 31, 2017

adityapatwardhan commented Oct 31, 2017

JamesWTruher left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iSazonov commented Nov 2, 2017

PowershellNinja commented Nov 3, 2017

iSazonov commented Nov 3, 2017

PowershellNinja commented Nov 3, 2017 via email

jpsnover left a comment

Choose a reason for hiding this comment

jpsnover commented Nov 6, 2017

iSazonov commented Nov 8, 2017

PowershellNinja commented Nov 8, 2017

iSazonov commented Nov 8, 2017

PowershellNinja Oct 24, 2017 •

edited

iSazonov Oct 25, 2017 •

edited

PowershellNinja commented Oct 31, 2017 •

edited