Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the declaration of new experimental features #8726

Merged
merged 3 commits into from
Jan 25, 2019
Merged

Simplify the declaration of new experimental features #8726

merged 3 commits into from
Jan 25, 2019

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jan 23, 2019 •
edited

PR Summary

Add a new private constructor to bake in the source and isEnabled parameters for declaring a new engine experimental feature.

PR Context

PR Checklist

@daxian-dbw daxian-dbw added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log CL-Engine Indicates that a PR should be marked as an engine change in the Change Log and removed CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log labels Jan 23, 2019
@adityapatwardhan
Copy link
Member

@daxian-dbw Please resolve CodeFactor issues.

@anmenaga anmenaga merged commit c35fd70 into PowerShell:master Jan 25, 2019
@daxian-dbw daxian-dbw deleted the exp branch January 26, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@BrucePay BrucePay Awaiting requested review from BrucePay

Assignees

@anmenaga anmenaga

Labels
CL-Engine Indicates that a PR should be marked as an engine change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daxian-dbw @adityapatwardhan @SteveL-MSFT @anmenaga