-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compliance to Coordinated build #8798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add it as a recommended extension
TravisEz13
requested review from
adityapatwardhan,
anmenaga,
daxian-dbw and
PaulHigin
as code owners
January 30, 2019 18:58
add comments Add a finish task and map all the leafs to it
TravisEz13
force-pushed
the
add_compliance_gh
branch
from
January 30, 2019 20:54
9906ecf
to
e5571bb
Compare
adityapatwardhan
requested changes
Jan 30, 2019
- template: templates/compliance.yml | ||
parameters: | ||
parentJobs: | ||
- build_windows_x64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also wait for Linux and macOS builds for running antivirus?
adityapatwardhan
approved these changes
Jan 30, 2019
All comments are non-blocking but should be fixed eventually. |
iSazonov
added
the
CL-Tools
Indicates that a PR should be marked as a tools change in the Change Log
label
Feb 1, 2019
TravisEz13
added
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
and removed
CL-Tools
Indicates that a PR should be marked as a tools change in the Change Log
labels
Feb 2, 2019
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
May 14, 2019
Add compliance to Coordinated build - Also switch to mac internal pool for release build - Also turn some duplicate tasks into templates - Also fix issue with vscode configuration which causes yaml files not to be recogized as yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add compliance to Coordinated build
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.[feature]
to your commit messages if the change is significant or affects feature tests