Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compliance to Coordinated build #8798

Merged
merged 11 commits into from
Jan 30, 2019

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Jan 30, 2019

PR Summary

Add compliance to Coordinated build

  • Also switch to mac internal pool for release build
  • Also turn some duplicate tasks into templates
  • Also fix issue with vscode configuration which causes yaml files not to be recogized as yaml

PR Context

PR Checklist

add comments
Add a finish task and map all the leafs to it
- template: templates/compliance.yml
parameters:
parentJobs:
- build_windows_x64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also wait for Linux and macOS builds for running antivirus?

@adityapatwardhan
Copy link
Member

All comments are non-blocking but should be fixed eventually.

@TravisEz13 TravisEz13 merged commit a872b8d into PowerShell:master Jan 30, 2019
@TravisEz13 TravisEz13 deleted the add_compliance_gh branch January 30, 2019 22:10
@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Feb 1, 2019
@TravisEz13 TravisEz13 added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log and removed CL-Tools Indicates that a PR should be marked as a tools change in the Change Log labels Feb 2, 2019
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request May 14, 2019
Add compliance to Coordinated build
  - Also switch to mac internal pool for release build
  - Also turn some duplicate tasks into templates
  - Also fix issue with vscode configuration which causes yaml files not to be recogized as yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants