-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor macOS CI so that tests run in parallel #9056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, just saw this and thought it could be simplified.
} | ||
else | ||
{ | ||
Write-Verbose "Tests did not fail! Nice job!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write-Verbose "Tests did not fail! Nice job!" | |
Write-Verbose "Tests passed! Nice job!" |
ed6ce6a
to
d883b25
Compare
fcac26c
to
3b766e4
Compare
@@ -0,0 +1,74 @@ | |||
if($PSVersionTable.PSEdition -ne 'Desktop') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is code that other that this imperative code to protect against loading in PowerShell core was just moved from CI.psm1
.vsts-ci/mac.yml
Outdated
displayName: Bootstrap | ||
condition: succeeded() | ||
- pwsh: | | ||
dir "$(System.ArtifactsDirectory)\*" -Recurse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dir
-> Get-ChildItem
.vsts-ci/templates/nix-test.yml
Outdated
$options = (Get-PSOptions) | ||
$rootPath = '$(System.ArtifactsDirectory)\bins' | ||
$originalRootPath = Split-Path -path $options.Output | ||
Write-Host "orp- '$originalRootPath'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove debug comments
Refactor macOS CI so that tests run in parallel - Also: - Fix bootstrap issue where curl was failing for a month (so obviously not needed) - Change Windows test stages to use PowerShell Core (where we can) to avoid compat issues ## PR Context This allows running all tests in about the same about of clock time.
PR Summary
Refactor macOS CI so that tests run in parallel
PR Context
This allows running all tests in about the same about of clock time.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.[feature]
to your commit messages if the change is significant or affects feature tests