Fix artifact Download issue in release build #9095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
approved these changes
Mar 8, 2019
| finalResults/powershell-*.tar.gz | ||
| results/powershell-*-osx-x64.tar.gz | ||
| downloadType: single | ||
| artifactName: finalResults |
There was a problem hiding this comment.
Is finalResults a folder or a single file? Is this change actually copies all items in the finalResults folder to $(System.ArtifactsDirectory)?
There was a problem hiding this comment.
This change, yes downloads all files from finalResults. I always hit some issue if I tried the filters, and this was faster than what we had before so I stopped here.
There was a problem hiding this comment.
You questions indicates you understood the change well enough.
There was a problem hiding this comment.
I saw finalResults appears in the build log as a folder :) A lucky guess
TravisEz13
added a commit
that referenced
this pull request
Mar 13, 2019
Fix artifact Download issue in release build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix artifact Download issue in release build
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests