Make command searcher not use wildcard search for execution #9202

TravisEz13 · 2019-03-22T18:05:39Z

PR Summary

Make command searcher not use wildcard search for execution

PR Context

This is a Defense in Depth fix to prevent people from accidentally running a script.

For example, if a user attempted to run .\[my1].ps1 and there is a 1.ps1 in the same folder. 1.ps1 would be executed instead.
The fix allows tab completion and Get-Command to continue to work with the wildcards ([], ?, and *).

PR Checklist

…s in path or not using wildcards in the path.

…g path

src/System.Management.Automation/engine/CommandSearcher.cs

iSazonov · 2019-03-22T18:33:53Z

If we want unambiguity, can we follow the practice we use in cmdlets? I mean that if name resolution returns several results, then throw.

/cc @mklement0

TravisEz13 · 2019-03-22T18:35:27Z

@iSazonov That code is already there. End the end, both code paths, use the same code. I doubt anyone actually wants to do execution based on wildcards. It can lead to executing unexpected files and VERY bad results.

mklement0 · 2019-03-22T19:22:56Z

Glad to see this is getting fixed; it addresses at least part of #4726, which also asks for the >, >> behavior to be fixed - will this PR address that too (haven't looked)?

TravisEz13 · 2019-03-22T19:34:38Z

@mklement0 The intent was not to fix that issue. As #4726 does not directly affect execution, I would not think that the issue would be considered a Defense in Depth fix and I'd prefer to get this fix in before addressing that issue.

mklement0 · 2019-03-22T19:37:32Z

Thanks for clarifying, @TravisEz13 (but note that #4726 is about execution as well).

src/System.Management.Automation/engine/CommandSearcher.cs

SteveL-MSFT

Nit comment remaining

SteveL-MSFT · 2019-04-01T23:37:28Z

build.psm1

-        [string]$Title = 'PowerShell Core Tests'
+        [string]$Title = 'PowerShell Core Tests',
+        [Parameter(ParameterSetName='Wait', Mandatory=$true,
+            HelpMessage='Wait for the debugger to attach to powershell before pester starts.  Debug builds only!')]


Suggested change

HelpMessage='Wait for the debugger to attach to powershell before pester starts. Debug builds only!')]

HelpMessage='Wait for the debugger to attach to PowerShell before Pester starts. Debug builds only!')]

test/powershell/engine/Basic/CommandDiscovery.Tests.ps1

iSazonov · 2019-04-03T03:48:15Z

Should we document the command searcher process in Docs repo?

TravisEz13 · 2019-04-03T05:18:52Z

The command searcher itself is an implementation detail. We should document the search order for command execution.

…ll#9202)

TravisEz13 added 6 commits March 22, 2019 10:58

Add ability for searcher to search for commands using either wildcard…

6060fd0

…s in path or not using wildcards in the path.

make get-command tell command searcher to use wildcards when searchin…

2343357

…g path

Add tests for the various cases

5e0523f

Address Paul's comments

9b8f2f8

make test names static

38f0111

Address Paul's comments (some offline)

f143e17

TravisEz13 added Breaking-Change breaking change that may affect users CL-Engine Indicates that a PR should be marked as an engine change in the Change Log labels Mar 22, 2019

TravisEz13 added this to the 6.2.0-GA-Consider milestone Mar 22, 2019

TravisEz13 requested review from BrucePay and daxian-dbw as code owners March 22, 2019 18:05

TravisEz13 requested review from PaulHigin and adityapatwardhan March 22, 2019 18:05

start using HasFlag

ffc4ce1

PaulHigin suggested changes Mar 22, 2019

View reviewed changes

src/System.Management.Automation/engine/CommandSearcher.cs Outdated Show resolved Hide resolved

src/System.Management.Automation/engine/CommandSearcher.cs Outdated Show resolved Hide resolved

TravisEz13 added 2 commits March 22, 2019 11:22

start using HasFlag in second location

539a0d0

Fix CodeFactor issues

f79768b

TravisEz13 force-pushed the fix_command_searcher branch from da63bff to 44e90c0 Compare March 22, 2019 19:30

TravisEz13 requested a review from PaulHigin March 22, 2019 19:45

TravisEz13 force-pushed the fix_command_searcher branch from 44e90c0 to f143e17 Compare March 22, 2019 19:48

mklement0 mentioned this pull request Mar 22, 2019

Some scripts / files with wildcard metacharacter [ in the file name or path cannot be invoked or redirected to #4726

Closed

Fix check in fullPath codePath

cdbf1e9

PaulHigin suggested changes Mar 22, 2019

View reviewed changes

src/System.Management.Automation/engine/CommandSearcher.cs Outdated Show resolved Hide resolved

Don't recreate resolvedPaths

4688ae8

PaulHigin approved these changes Mar 22, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

SteveL-MSFT approved these changes Apr 1, 2019

View reviewed changes

TravisEz13 added 2 commits April 1, 2019 16:49

delete pending tests which were made negative tests

85a8c85

fix PR feedback

0e4c566

adityapatwardhan reviewed Apr 1, 2019

View reviewed changes

test/powershell/engine/Basic/CommandDiscovery.Tests.ps1 Outdated Show resolved Hide resolved

Update test/powershell/engine/Basic/CommandDiscovery.Tests.ps1

66fc031

This comment has been minimized.

Sign in to view

iSazonov reviewed Apr 2, 2019

View reviewed changes

test/powershell/engine/Basic/CommandDiscovery.Tests.ps1 Outdated Show resolved Hide resolved

Update test/powershell/engine/Basic/CommandDiscovery.Tests.ps1

5d7bc15

TravisEz13 commented Apr 2, 2019

View reviewed changes

test/powershell/engine/Basic/CommandDiscovery.Tests.ps1 Outdated Show resolved Hide resolved

Update test/powershell/engine/Basic/CommandDiscovery.Tests.ps1

c965097

adityapatwardhan approved these changes Apr 2, 2019

View reviewed changes

adityapatwardhan merged commit 5e4b4d1 into PowerShell:master Apr 2, 2019

TravisEz13 deleted the fix_command_searcher branch April 2, 2019 18:57

TravisEz13 mentioned this pull request Apr 3, 2019

Document the Command Path Precedence MicrosoftDocs/PowerShell-Docs#4105

Closed

8 tasks

iSazonov assigned adityapatwardhan Apr 3, 2019

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 4, 2019

Make command searcher not use wildcard search for execution (PowerShe…

52b2a26

…ll#9202)

mklement0 mentioned this pull request Apr 15, 2019

Namespace variable notation unexpectedly treats paths as wildcard expressions #9225

Closed

daxian-dbw mentioned this pull request Apr 16, 2019

CommandSearcher: treat invalid wildcard path as literal #7399

Closed

11 tasks

iSazonov mentioned this pull request Apr 18, 2019

NullReferenceException in Get-Command #9396

Closed

This was referenced Jun 1, 2019

v7.0.0-preview.1: can't open a URL with Start-Process #9791

Closed

Fix use of Start-Process http://bing.com #9793

Merged

TravisEz13 mentioned this pull request Sep 6, 2019

Tab complete changed in inconvenient way for PS7 Preview3 #10482

Closed

mklement0 mentioned this pull request Nov 6, 2019

command with wildcard characters on path cannot be executed #10997

Closed

mklement0 mentioned this pull request Apr 5, 2022

When New-Item -Path is combined with -Name, the -Path argument is inappropriately treated as a wildcard expression #17106

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make command searcher not use wildcard search for execution #9202

Make command searcher not use wildcard search for execution #9202

TravisEz13 commented Mar 22, 2019 •

edited

iSazonov commented Mar 22, 2019

TravisEz13 commented Mar 22, 2019 •

edited

mklement0 commented Mar 22, 2019

TravisEz13 commented Mar 22, 2019

mklement0 commented Mar 22, 2019

This comment has been minimized.

This comment has been minimized.

SteveL-MSFT left a comment

SteveL-MSFT Apr 1, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

iSazonov commented Apr 3, 2019

TravisEz13 commented Apr 3, 2019

	HelpMessage='Wait for the debugger to attach to powershell before pester starts. Debug builds only!')]
	HelpMessage='Wait for the debugger to attach to PowerShell before Pester starts. Debug builds only!')]

Make command searcher not use wildcard search for execution #9202

Make command searcher not use wildcard search for execution #9202

Conversation

TravisEz13 commented Mar 22, 2019 • edited

PR Summary

PR Context

PR Checklist

iSazonov commented Mar 22, 2019

TravisEz13 commented Mar 22, 2019 • edited

mklement0 commented Mar 22, 2019

TravisEz13 commented Mar 22, 2019

mklement0 commented Mar 22, 2019

This comment has been minimized.

This comment has been minimized.

SteveL-MSFT left a comment

Choose a reason for hiding this comment

SteveL-MSFT Apr 1, 2019

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

iSazonov commented Apr 3, 2019

TravisEz13 commented Apr 3, 2019

TravisEz13 commented Mar 22, 2019 •

edited

TravisEz13 commented Mar 22, 2019 •

edited