Added more tests for import-alias by file, regarding parsing 'difficult' aliases strings #9247

SytzeAndr · 2019-03-29T15:05:00Z

PR Summary

According to this comment by daxian-dbw, "abc""def"should be parsed to abc"def. This was not covered in the old test cases, but should be now with this PR.

This PR adds tests for the import-alias by file, in a seperate PR as discussed in #9091. After this gets accepted, it should be possible to start refactoring import-alias. Details about this refactorization can be found in #9091 .

This pr adds the following test cases for import alias by file:

"abc""def" should parse to abc"def
"aaa" should parse to aaa
"a,b" should parse to a,b
If an alias file is read with a line containing more than four values, throw an error
If an alias file is read with a line containing less than four values, throw an error

If more exhaustive testing is required, please let me know.

PR Checklist

…st for including a quote character fails, as illegal characters are in the path

test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1

…ked by get-alias instead of executing the alias, which is a cleaner method to check whether the alias is imported correctly

test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1

…g --BeExactly

…e is present. The tests should now pass

SytzeAndr · 2019-03-31T12:23:05Z

We should now be able to safely delete pesteralias.txt in PowerShell\test\powershell\Modules\Microsoft.PowerShell.Utility\assets since the file to read is created in a temporary test folder and deleted afterwards. I think it is nice to remove it, any opinions on this?

test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1

SytzeAndr · 2019-03-31T20:02:21Z

I accidently commited the content of #9091 branch into this branch. I'll try to undo it

@SytzeAndr SytzeAndr requested review from JamesWTruher and PaulHigin as code owners

apparently this happened during the accidental merge due to code ownership. Although I fixed that the commits were reverted, I don't know if this request for review is a problem of any kind.

…alid file, it now creates a new file only containing the invalid alias

SytzeAndr · 2019-04-02T16:21:17Z

All suggestions are implemented,thanks @iSazonov.

test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1

… test when the alias is not imported yet

SytzeAndr · 2019-04-03T15:39:11Z

@SteveL-MSFT I implemented all your suggestions

SteveL-MSFT

LGTM

iSazonov

@SytzeAndr Thanks for fixing all style issues in the old file!

test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

iSazonov · 2019-04-11T03:52:44Z

@adityapatwardhan Could you please update your review?

adityapatwardhan · 2019-04-11T17:40:49Z

@SytzeAndr Thank you for your contribution

SytzeAndr added 2 commits March 29, 2019 15:57

added more tests regarding parsing difficult aliases. However, the te…

180f4ae

…st for including a quote character fails, as illegal characters are in the path

added tests for parsing invalid files: should throw an error

674425d

SytzeAndr changed the title ~~WIP: added more tests for import-alias, regarding parsing difficult aliases~~ Added more tests for import-alias, regarding parsing difficult aliases Mar 29, 2019

SytzeAndr mentioned this pull request Mar 29, 2019

csv parser used in import alias refactor #9091

Closed

11 tasks

SytzeAndr changed the title ~~Added more tests for import-alias, regarding parsing difficult aliases~~ Added more tests for import-alias, regarding parsing 'difficult' aliases strings Mar 29, 2019

iSazonov requested review from adityapatwardhan and SteveL-MSFT March 29, 2019 17:38

iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Mar 29, 2019

iSazonov reviewed Mar 29, 2019

View reviewed changes

SytzeAndr changed the title ~~Added more tests for import-alias, regarding parsing 'difficult' aliases strings~~ Added more tests for import-alias by file, regarding parsing 'difficult' aliases strings Mar 30, 2019

iSazonov suggestions for testing: added errorID, asserts are now chec…

5c2835b

…ked by get-alias instead of executing the alias, which is a cleaner method to check whether the alias is imported correctly

iSazonov reviewed Mar 30, 2019

View reviewed changes

SytzeAndr added 3 commits March 31, 2019 13:32

iSasonov suggestions: adding explicit parameters, fixed type regardin…

0b2237b

…g --BeExactly

wrong indent fixed

8013cde

removed the initializations and fixed the test for get-alias when non…

d2f1311

…e is present. The tests should now pass

iSazonov reviewed Mar 31, 2019

View reviewed changes

iSazonov assigned adityapatwardhan Mar 31, 2019

SytzeAndr requested review from JamesWTruher and PaulHigin as code owners March 31, 2019 19:51

SytzeAndr force-pushed the csv_import-alias_tests branch from 0e7b95f to d2f1311 Compare March 31, 2019 20:13

SytzeAndr added 3 commits March 31, 2019 22:25

iSazonov suggestions about comments, and I renamed some variables

a1ccb76

reference to variable instead of to a string

ee4d514

instead of adding the invalid aliases to the content to create an inv…

c17d374

…alid file, it now creates a new file only containing the invalid alias

SteveL-MSFT requested changes Apr 2, 2019

View reviewed changes

SteveL-MSFT and others added 3 commits April 3, 2019 11:48

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

1988aad

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

dbf0663

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

e33ad15

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

SteveL-MSFT and others added 10 commits April 3, 2019 11:49

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

4369b0b

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

122caf3

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

7d58d9a

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

4c52d24

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

e907631

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

21da70c

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

dbfc947

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

7f76418

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

7057b97

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

5d40567

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

iSazonov reviewed Apr 3, 2019

View reviewed changes

SytzeAndr added 4 commits April 3, 2019 12:25

removed the afterAll, tests are now with parameters

38a2acb

resolved merge conflicts: checkoing for null one level higher for the…

c03faa8

… test when the alias is not imported yet

iSazonov suggestions, regarding spacing

8db2dec

replaced all tabs with four spaces

a98d2b1

SteveL-MSFT approved these changes Apr 3, 2019

View reviewed changes

iSazonov approved these changes Apr 4, 2019

View reviewed changes

adityapatwardhan requested changes Apr 8, 2019

View reviewed changes

test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Alias.Tests.ps1 Outdated Show resolved Hide resolved

adityapatwardhan and others added 2 commits April 10, 2019 18:42

Update test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Al…

d6ea184

…ias.Tests.ps1 Co-Authored-By: SytzeAndr <s.p.e.andringa@student.tudelft.nl>

removed the extra bracket introduced

fe82633

adityapatwardhan approved these changes Apr 11, 2019

View reviewed changes

adityapatwardhan merged commit 4884317 into PowerShell:master Apr 11, 2019

adityapatwardhan added this to the 7.0.0-preview.1 milestone Apr 11, 2019

SytzeAndr deleted the csv_import-alias_tests branch April 15, 2019 12:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added more tests for import-alias by file, regarding parsing 'difficult' aliases strings #9247

Added more tests for import-alias by file, regarding parsing 'difficult' aliases strings #9247

SytzeAndr commented Mar 29, 2019 •

edited

SytzeAndr commented Mar 31, 2019 •

edited

SytzeAndr commented Mar 31, 2019 •

edited

SytzeAndr commented Apr 2, 2019 •

edited

SytzeAndr commented Apr 3, 2019

SteveL-MSFT left a comment

iSazonov left a comment

iSazonov commented Apr 11, 2019

adityapatwardhan commented Apr 11, 2019

Added more tests for import-alias by file, regarding parsing 'difficult' aliases strings #9247

Added more tests for import-alias by file, regarding parsing 'difficult' aliases strings #9247

Conversation

SytzeAndr commented Mar 29, 2019 • edited

PR Summary

PR Checklist

SytzeAndr commented Mar 31, 2019 • edited

SytzeAndr commented Mar 31, 2019 • edited

SytzeAndr commented Apr 2, 2019 • edited

SytzeAndr commented Apr 3, 2019

SteveL-MSFT left a comment

Choose a reason for hiding this comment

iSazonov left a comment

Choose a reason for hiding this comment

iSazonov commented Apr 11, 2019

adityapatwardhan commented Apr 11, 2019

SytzeAndr commented Mar 29, 2019 •

edited

SytzeAndr commented Mar 31, 2019 •

edited

SytzeAndr commented Mar 31, 2019 •

edited

SytzeAndr commented Apr 2, 2019 •

edited