Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secret scanning to CI #9249

Merged
merged 8 commits into from
Mar 30, 2019
Merged

Add secret scanning to CI #9249

merged 8 commits into from
Mar 30, 2019

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Mar 29, 2019 •
edited

PR Summary

Add secret scanning to CI

PR Context

This should prevent us from having any secrets in our history

PR Checklist

@TravisEz13 TravisEz13 marked this pull request as ready for review March 29, 2019 20:02
PaulHigin
PaulHigin approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13

This comment has been minimized.

Sign in to view
@PoshChan

This comment has been minimized.

Sign in to view
@TravisEz13
Copy link
Member Author

@PoshChan Please remind me in 24 hours

@PoshChan
Copy link
Collaborator

@TravisEz13, will remind you in 24 hours

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 29, 2019
@TravisEz13 TravisEz13 added this to the 6.3.0-preview.1 milestone Mar 29, 2019
@TravisEz13 TravisEz13 merged commit 14980aa into PowerShell:master Mar 30, 2019
@TravisEz13 TravisEz13 deleted the Add_credscan branch March 30, 2019 17:17
@PoshChan
Copy link
Collaborator

@TravisEz13, this is the reminder you requested 24 hours ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@PaulHigin PaulHigin PaulHigin approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga anmenaga is a code owner

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

Assignees

@TravisEz13 TravisEz13

Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Milestone
7.0.0-preview.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TravisEz13 @PoshChan @adityapatwardhan @PaulHigin