Update tests to account for when $PSHOME is readonly #9279

SteveL-MSFT · 2019-04-03T03:27:27Z

PR Summary

Add new Test-CanWriteToPsHome helper function to determine if current pwsh can write to $PSHOME. If it can't it will skip that test. Some other small test changes to account for differences running locally vs in CI.

PR Context

Snap and AppX packages of PSCore6 have a $PSHOME that is read-only. Tests expect that when elevated/root it can write to $PSHOME which is not always the case so these tests fail.

Related #9278

PR Checklist

PoshChan · 2019-04-03T03:40:35Z

@SteveL-MSFT, your last commit had failures in PowerShell-CI-windows

PoshChan · 2019-04-03T03:40:43Z

@SteveL-MSFT, your last commit had failures in PowerShell-CI-linux

PoshChan · 2019-04-03T03:40:51Z

@SteveL-MSFT, your last commit had failures in PowerShell-CI-macos

PoshChan · 2019-04-03T03:49:03Z

@SteveL-MSFT, your last commit had failures in PowerShell-CI-macos

PoshChan · 2019-04-03T03:49:04Z

@SteveL-MSFT, your last commit had failures in PowerShell-CI-linux

PoshChan · 2019-04-03T03:49:25Z

@SteveL-MSFT, your last commit had failures in PowerShell-CI-windows

iSazonov · 2019-04-03T10:51:28Z

test/powershell/Modules/Microsoft.PowerShell.Core/PSSessionConfiguration.Tests.ps1

@@ -1,12 +1,16 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License.
+
+Import-Module HelpersCommon


Doesn't autoloading work?

Only if you have the test modules in your PSModulePath. If you run the tests directly instead of via Invoke-PSPester, I figured not finding the module was a better error message than not finding the cmdlet

I wonder that we add this again because previously we removed all explicit import-module from all test files. Calling Invoke-PSPester once in a session could resolves the problem.

I'm ok either way on this. Some of test scripts already explicitly import helper modules.

test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1

TravisEz13 · 2019-04-03T17:18:07Z

How many of these issues does the product rely on writing to $PSHome. We should file product bugs issue for these cases?

…nPolicy.Tests.ps1 Co-Authored-By: SteveL-MSFT <slee@microsoft.com>

SteveL-MSFT · 2019-04-03T21:06:28Z

@TravisEz13 the related issue above links to the product issues we should change

SteveL-MSFT · 2019-04-04T17:01:15Z

@PoshChan Please get failures

PoshChan · 2019-04-04T17:02:06Z

@SteveL-MSFT, your last commit had 4 failures in PowerShell-CI-linux
JEA session Transcript script test.Configuration name should be in the transcript header

The term 'Unregister-PSSessionConfiguration' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/engine/Remoting/RemoteSession.Basic.Tests.ps1: line 75
75:             Unregister-PSSessionConfiguration -Name JEA -Force -ErrorAction SilentlyContinue

JEA session Get-Help test.Get-Help should work in JEA sessions

The term 'Unregister-PSSessionConfiguration' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/engine/Remoting/RemoteSession.Basic.Tests.ps1: line 114
114:             Unregister-PSSessionConfiguration -Name JEA -Force -ErrorAction SilentlyContinue

Validate Set-ExecutionPolicy -Scope (Admin).-Scope LocalMachine is Settable, but overridden

Operation is not supported on this platform.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1: line 1163
1163:             Set-ExecutionPolicy -Scope Process -ExecutionPolicy Undefined

Validate Set-ExecutionPolicy -Scope (Admin).-Scope LocalMachine is Settable

Operation is not supported on this platform.
at <ScriptBlock>, /home/vsts/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1: line 1175
1175:             Set-ExecutionPolicy -Scope Process -ExecutionPolicy Undefined

PoshChan · 2019-04-04T17:02:08Z

@SteveL-MSFT, your last commit had 4 failures in PowerShell-CI-macos
JEA session Transcript script test.Configuration name should be in the transcript header

The term 'Unregister-PSSessionConfiguration' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
at <ScriptBlock>, /Users/vsts/agent/2.149.2/work/1/s/test/powershell/engine/Remoting/RemoteSession.Basic.Tests.ps1: line 75
75:             Unregister-PSSessionConfiguration -Name JEA -Force -ErrorAction SilentlyContinue

JEA session Get-Help test.Get-Help should work in JEA sessions

The term 'Unregister-PSSessionConfiguration' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
at <ScriptBlock>, /Users/vsts/agent/2.149.2/work/1/s/test/powershell/engine/Remoting/RemoteSession.Basic.Tests.ps1: line 114
114:             Unregister-PSSessionConfiguration -Name JEA -Force -ErrorAction SilentlyContinue

Validate Set-ExecutionPolicy -Scope (Admin).-Scope LocalMachine is Settable, but overridden

Operation is not supported on this platform.
at <ScriptBlock>, /Users/vsts/agent/2.149.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1: line 1163
1163:             Set-ExecutionPolicy -Scope Process -ExecutionPolicy Undefined

Validate Set-ExecutionPolicy -Scope (Admin).-Scope LocalMachine is Settable

Operation is not supported on this platform.
at <ScriptBlock>, /Users/vsts/agent/2.149.2/work/1/s/test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1: line 1175
1175:             Set-ExecutionPolicy -Scope Process -ExecutionPolicy Undefined

PoshChan · 2019-04-04T17:02:09Z

@SteveL-MSFT, test results were not published for PowerShell-CI-static-analysis at vstfs:///Build/Build/19330

PoshChan · 2019-04-04T17:02:10Z

@SteveL-MSFT, test results were not published for PowerShell-CI-windows at vstfs:///Build/Build/19331

SteveL-MSFT · 2019-04-04T17:04:48Z

@PoshChan Please retry windows

PoshChan · 2019-04-04T17:05:00Z

@SteveL-MSFT, successfully started retry of PowerShell-CI-Windows

iSazonov · 2019-04-04T17:10:19Z

It seems in last days CI-Windows fail frequently.

TravisEz13 · 2019-04-04T22:00:26Z

@iSazonov You can dig into the failures here (I'm using the daily to remove failures caused by PRs): https://powershell.visualstudio.com/PowerShell/_build?definitionId=32&view=ms.vss-pipelineanalytics-web.new-build-definition-pipeline-analytics-view-cardmetrics

Failures for the last 30 days

iSazonov · 2019-04-05T03:31:53Z

@TravisEz13 Thanks! Why is there 200% "200% of pipeline failures are due to failures in task - Test"?

TravisEz13 · 2019-04-05T06:00:26Z

@iSazonov The Pipeline pass rate analysis is in beta. I assume it is a bug.

Moved check if able to write to $PSHome as way to skip test to `BeforeAll` which already contained a check if running on Windows. ## PR Context As part #9279, tests were updated to be skipped if the test requires writing to `$PSHome` but is not able to. However, these tests already had a skip mechanism in place so the additional check caused the test to run when it should have skipped. Co-authored-by: Travis Plunk <github@ez13.net>

Co-Authored-By: SteveL-MSFT <slee@microsoft.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>

Moved check if able to write to $PSHome as way to skip test to `BeforeAll` which already contained a check if running on Windows. ## PR Context As part #9279, tests were updated to be skipped if the test requires writing to `$PSHome` but is not able to. However, these tests already had a skip mechanism in place so the additional check caused the test to run when it should have skipped. Co-authored-by: Travis Plunk <github@ez13.net>

update tests to account for when $PSHOME is readonly

1071d66

SteveL-MSFT assigned TravisEz13 Apr 3, 2019

SteveL-MSFT requested review from TravisEz13 and adityapatwardhan April 3, 2019 03:27

SteveL-MSFT requested review from anmenaga, daxian-dbw and PaulHigin as code owners April 3, 2019 03:27

SteveL-MSFT force-pushed the pshome-readonly branch from 3527532 to adaa749 Compare April 3, 2019 03:48

address scriptanalyzer issue

1849166

SteveL-MSFT force-pushed the pshome-readonly branch from adaa749 to 1849166 Compare April 3, 2019 03:57

iSazonov reviewed Apr 3, 2019

View reviewed changes

Update test/powershell/Modules/Microsoft.PowerShell.Security/Executio…

9045130

…nPolicy.Tests.ps1 Co-Authored-By: SteveL-MSFT <slee@microsoft.com>

TravisEz13 approved these changes Apr 4, 2019

View reviewed changes

TravisEz13 merged commit b8317de into PowerShell:master Apr 5, 2019

SteveL-MSFT deleted the pshome-readonly branch April 5, 2019 16:32

SteveL-MSFT mentioned this pull request Apr 5, 2019

Fix skipping of tests in RemoteSession.Basic.Tests.ps1 #9304

Merged

10 tasks

TravisEz13 added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Apr 7, 2019

TravisEz13 added this to the 7.0.0-preview.1 milestone Apr 7, 2019

TravisEz13 modified the milestones: 7.0.0-preview.1, 6.2.1 Apr 15, 2019

TravisEz13 added a commit that referenced this pull request Apr 15, 2019

Update tests to account for when $PSHOME is readonly (#9279)

efe9f99

Co-Authored-By: SteveL-MSFT <slee@microsoft.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update tests to account for when $PSHOME is readonly #9279

Update tests to account for when $PSHOME is readonly #9279

SteveL-MSFT commented Apr 3, 2019 •

edited

PoshChan commented Apr 3, 2019

PoshChan commented Apr 3, 2019

PoshChan commented Apr 3, 2019

PoshChan commented Apr 3, 2019

PoshChan commented Apr 3, 2019

PoshChan commented Apr 3, 2019

iSazonov Apr 3, 2019

SteveL-MSFT Apr 3, 2019

iSazonov Apr 4, 2019

SteveL-MSFT Apr 4, 2019

TravisEz13 commented Apr 3, 2019

SteveL-MSFT commented Apr 3, 2019

SteveL-MSFT commented Apr 4, 2019

PoshChan commented Apr 4, 2019

PoshChan commented Apr 4, 2019

PoshChan commented Apr 4, 2019

PoshChan commented Apr 4, 2019

SteveL-MSFT commented Apr 4, 2019

PoshChan commented Apr 4, 2019

iSazonov commented Apr 4, 2019

TravisEz13 commented Apr 4, 2019 •

edited

iSazonov commented Apr 5, 2019

TravisEz13 commented Apr 5, 2019 •

edited

Update tests to account for when $PSHOME is readonly #9279

Update tests to account for when $PSHOME is readonly #9279

Conversation

SteveL-MSFT commented Apr 3, 2019 • edited

PR Summary

PR Context

PR Checklist

PoshChan commented Apr 3, 2019

PoshChan commented Apr 3, 2019

PoshChan commented Apr 3, 2019

PoshChan commented Apr 3, 2019

PoshChan commented Apr 3, 2019

PoshChan commented Apr 3, 2019

iSazonov Apr 3, 2019

Choose a reason for hiding this comment

SteveL-MSFT Apr 3, 2019

Choose a reason for hiding this comment

iSazonov Apr 4, 2019

Choose a reason for hiding this comment

SteveL-MSFT Apr 4, 2019

Choose a reason for hiding this comment

TravisEz13 commented Apr 3, 2019

SteveL-MSFT commented Apr 3, 2019

SteveL-MSFT commented Apr 4, 2019

PoshChan commented Apr 4, 2019

PoshChan commented Apr 4, 2019

PoshChan commented Apr 4, 2019

PoshChan commented Apr 4, 2019

SteveL-MSFT commented Apr 4, 2019

PoshChan commented Apr 4, 2019

iSazonov commented Apr 4, 2019

TravisEz13 commented Apr 4, 2019 • edited

iSazonov commented Apr 5, 2019

TravisEz13 commented Apr 5, 2019 • edited

SteveL-MSFT commented Apr 3, 2019 •

edited

TravisEz13 commented Apr 4, 2019 •

edited

TravisEz13 commented Apr 5, 2019 •

edited