Enable building of msix package #9289

SteveL-MSFT · 2019-04-03T20:55:15Z

PR Summary

Add support in packaging.psm1 to produce a .msix AppX package. Update the docker image to use the new msix package type. Update the associated yml files so AzDevOps performs the build.

PR Context

Enable publishing PSCore6 to Microsoft Store

PR Checklist

tools/packaging/packaging.psm1

tools/releaseBuild/Images/microsoft_powershell_windowsservercore/Dockerfile

tools/packaging/packaging.psm1

assets/AppxManifest.xml

tools/packaging/packaging.psm1

…or docker

also fixed the search for makeappx when running locally

tools/releaseBuild/azureDevOps/templates/upload.yml

wjk · 2019-04-04T23:45:55Z

We would probably want to add the following XML elements to the manifest:

<Properties>
  <desktop6:RegistryWriteVirtualization>disabled</desktop6:RegistryWriteVirtualization>
</Properties>
<!-- other content... -->
<Capabilities>
  <rescap:Capability Name="unvirtualizedResources" />
</Capabilities>

This will instruct Windows to allow the packaged copy of PowerShell to modify the system Registry directly. Without it, PowerShell's Registry manipulation features will not function properly (the changes will be visible only to PowerShell), vastly impairing the usefulness of the program.

Note that users will need to be running 19H1 for this to work. The use of the desktop6 namespace should not impair loading of the package on downlevel versions of Windows 10 (assuming IgnorableNamespaces is used), but the capability might.

SteveL-MSFT · 2019-04-05T02:14:16Z

@wjk Thanks for that snippet! That should resolve the issue I see with using the registry provider from the msix. Will update the manifest.

SteveL-MSFT · 2019-04-05T04:17:41Z

@wjk With those additions, it doesn't fix some issues with the msix package in that Move-Item, Copy-Item and Rename-Item doesn't work with registry provider when elevated and against HKLM:. New-Item and Remove-Item do work. And all cmdlets seem to work against HKCU:.

fix packaging to create resources.pri so that taskbar icon doesn't have background border fix naming of package to align with msi package

wjk · 2019-04-05T14:25:43Z

@SteveL-MSFT Unfortunately, I'm not running 19H1 yet, so I can’t help debug your HKLM issue. It seems really weird that some of the registry cmdlets would work, but others don’t. Do you see an error message, or do the changes simply silently fail?

SteveL-MSFT · 2019-04-05T16:24:48Z

@wjk Getting an Access Denied error when attempting a move, rename, or copy. Here's the stacktace:

PSMessageDetails      :
Exception             : System.Security.SecurityException: Requested registry access is not allowed.
                           at Microsoft.Win32.ThrowHelper.ThrowSecurityException(String msg)
                           at Microsoft.Win32.RegistryKey.InternalOpenSubKeyCore(String name, Boolean writable,
                        Boolean throwOnPermissionFailure)
                           at Microsoft.PowerShell.Commands.RegistryWrapper.OpenSubKey(String name, Boolean writable)
                           at Microsoft.PowerShell.Commands.RegistryProvider.GetRegkeyForPath(String path, Boolean
                        writeAccess)
                           at Microsoft.PowerShell.Commands.RegistryProvider.CopyRegistryKey(IRegistryWrapper key,
                        String path, String destination, Boolean recurse, Boolean streamResult, Boolean
                        streamFirstOnly)
                           at Microsoft.PowerShell.Commands.RegistryProvider.CopyItem(String path, String destination,
                        Boolean recurse)
TargetObject          : HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\PowerShell\3\test\test
CategoryInfo          : PermissionDenied: (HKEY_LOCAL_MACHINE\\u2026erShell\3\test\test:String) [Copy-Item],
                        SecurityException
FullyQualifiedErrorId : System.Security.SecurityException,Microsoft.PowerShell.Commands.CopyItemCommand
ErrorDetails          :
InvocationInfo        : System.Management.Automation.InvocationInfo
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo : {0, 1}

TravisEz13 · 2019-04-05T23:37:31Z

assets/AppxManifest.xml

+  </Properties>
+
+  <Dependencies>
+    <TargetDeviceFamily Name="Windows.Universal" MinVersion="10.0.17763.0" MaxVersionTested="10.0.17763.0" />


I tried the msix on 1803 and it didn't install understand msix, I think it only supports .appx.

Not quite related, but FYI
https://github.com/Microsoft/msix-packaging/tree/master/preview/Win7Msix

We can update the version information once we verify it'll work on those versions.

tools/releaseBuild/Images/microsoft_powershell_windowsservercore/PowerShellPackage.ps1

PoshChan · 2019-04-15T20:34:42Z

@SteveL-MSFT, your last commit had 1 failures in PowerShell-CI-macos
Validate 'Save-Help -DestinationPath for all PowerShell Core modules..Validate Save-Help for the 'Microsoft.PowerShell.Core' module

Expected $null, but got 'Microsoft.PowerShell.Core_00000000-0000-0000-0000-000000000000_en-US_HelpContent.zip'.
at <ScriptBlock>, /Users/vsts/agent/2.149.2/work/1/s/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1: line 332
332:     $expectedCompressedFile | Should -Be $compressedFile

SteveL-MSFT · 2019-04-15T21:10:13Z

@PoshChan please retry macos

PoshChan · 2019-04-15T21:11:32Z

@SteveL-MSFT, successfully started retry of PowerShell-CI-macOS

Add support in packaging.psm1 to produce a .msix AppX package. Update the docker image to use the new msix package type. Update the associated yml files so AzDevOps performs the build. ## PR Context Enable publishing PSCore6 to Microsoft Store

SteveL-MSFT added 4 commits April 3, 2019 12:54

enable building of msix package

e947409

update packaging to build for msix

a258c14

add building of the msix to docker image

665907b

update azdevops ymls to sign and publish msix

8d03a50

SteveL-MSFT assigned TravisEz13 Apr 3, 2019

SteveL-MSFT requested a review from TravisEz13 April 3, 2019 20:55

SteveL-MSFT requested review from adityapatwardhan, anmenaga, daxian-dbw and PaulHigin as code owners April 3, 2019 20:55

adityapatwardhan requested changes Apr 3, 2019

View reviewed changes

tools/packaging/packaging.psm1 Outdated Show resolved Hide resolved

tools/packaging/packaging.psm1 Outdated Show resolved Hide resolved

tools/packaging/packaging.psm1 Outdated Show resolved Hide resolved

address Aditya's feedback

37ef942

SteveL-MSFT force-pushed the create-appx branch from 401c79f to 37ef942 Compare April 3, 2019 21:37

TravisEz13 reviewed Apr 3, 2019

View reviewed changes

tools/releaseBuild/Images/microsoft_powershell_windowsservercore/Dockerfile Outdated Show resolved Hide resolved

iSazonov reviewed Apr 4, 2019

View reviewed changes

tools/packaging/packaging.psm1 Outdated Show resolved Hide resolved

assets/AppxManifest.xml Outdated Show resolved Hide resolved

tools/packaging/packaging.psm1 Show resolved Hide resolved

SteveL-MSFT added 4 commits April 4, 2019 12:58

address Ilya and Travis' feedback

c5a385a

specify that the msix only works on 1809, fix searching of makeappx f…

77503e7

…or docker

makeappx is very specific about version strings, need to add revision

fa12267

also fixed the search for makeappx when running locally

enable build for arm/arm64 and update expected artifacts

d1407e6

TravisEz13 reviewed Apr 4, 2019

View reviewed changes

tools/releaseBuild/azureDevOps/templates/upload.yml Show resolved Hide resolved

SteveL-MSFT added 2 commits April 4, 2019 21:36

add capability to not use virtualized resources

3426a5a

fix packaging to create resources.pri so that taskbar icon doesn't have background border fix naming of package to align with msi package

address scriptanalyzer issue

80fd045

SteveL-MSFT added 3 commits April 5, 2019 11:04

update blog to include makepri

e20c7cd

enable build for arm32 and arm64

15df532

add arm32 and arm64 to signing

7cd1e1d

spell Authenticode correctly

1250f6e

TravisEz13 reviewed Apr 5, 2019

View reviewed changes

TravisEz13 approved these changes Apr 5, 2019

View reviewed changes

adityapatwardhan approved these changes Apr 15, 2019

View reviewed changes

tools/releaseBuild/Images/microsoft_powershell_windowsservercore/PowerShellPackage.ps1 Outdated Show resolved Hide resolved

address Aditya's feedback

0aa6e19

TravisEz13 merged commit 73114ee into PowerShell:master Apr 16, 2019

TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 16, 2019

TravisEz13 added this to the 7.0.0-preview.1 milestone Apr 16, 2019

saschanaz mentioned this pull request Oct 1, 2019

UWP/Microsoft Store package nodejs/node#25519

Closed

SteveL-MSFT deleted the create-appx branch March 10, 2020 21:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable building of msix package #9289

Enable building of msix package #9289

SteveL-MSFT commented Apr 3, 2019 •

edited

wjk commented Apr 4, 2019

SteveL-MSFT commented Apr 5, 2019

SteveL-MSFT commented Apr 5, 2019

wjk commented Apr 5, 2019

SteveL-MSFT commented Apr 5, 2019

TravisEz13 Apr 5, 2019

SteveL-MSFT Apr 6, 2019

TravisEz13 Apr 6, 2019

SteveL-MSFT Apr 6, 2019

PoshChan commented Apr 15, 2019

SteveL-MSFT commented Apr 15, 2019

PoshChan commented Apr 15, 2019

Enable building of msix package #9289

Enable building of msix package #9289

Conversation

SteveL-MSFT commented Apr 3, 2019 • edited

PR Summary

PR Context

PR Checklist

wjk commented Apr 4, 2019

SteveL-MSFT commented Apr 5, 2019

SteveL-MSFT commented Apr 5, 2019

wjk commented Apr 5, 2019

SteveL-MSFT commented Apr 5, 2019

TravisEz13 Apr 5, 2019

Choose a reason for hiding this comment

SteveL-MSFT Apr 6, 2019

Choose a reason for hiding this comment

TravisEz13 Apr 6, 2019

Choose a reason for hiding this comment

SteveL-MSFT Apr 6, 2019

Choose a reason for hiding this comment

PoshChan commented Apr 15, 2019

SteveL-MSFT commented Apr 15, 2019

PoshChan commented Apr 15, 2019

SteveL-MSFT commented Apr 3, 2019 •

edited