Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trigonometric func and better sqrt implementation #1390

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: trigonometric func and better sqrt implementation #1390

wants to merge 2 commits into from

Conversation

kaan2463
Copy link

@kaan2463 kaan2463 commented May 3, 2024

Description of Change

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
Trigonometric func and better sqrt implementation

kaan2463 and others added 2 commits May 2, 2024 22:26
@kaan2463
trigonometric functions are implemented by using Taylor series
ccb9363 
a better implementation of sqrt func by using Newton-Raphson method
docs: comments have been arranged!
8db6007 
test: asserts have been added!
@kaan2463 kaan2463 changed the title Trigonometric func and better sqrt implementation feat: trigonometric func and better sqrt implementation May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

@tjgurwara99 tjgurwara99 Awaiting requested review from tjgurwara99 tjgurwara99 is a code owner

@alexpantyukhin alexpantyukhin Awaiting requested review from alexpantyukhin alexpantyukhin is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kaan2463