Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode issue for invite user with email #7513

Open
Akib-Vijapura opened this issue Sep 27, 2023 · 4 comments · May be fixed by #7532
Open

Dark mode issue for invite user with email #7513

Akib-Vijapura opened this issue Sep 27, 2023 · 4 comments · May be fixed by #7532
Labels
bug Something isn't working platform roadmap

Comments

@Akib-Vijapura
Copy link

Version Information

Version 2.17.5-ee2.5.10-cloud2.0.9

Environment

What is the expected behaviour?

In dark mode, the "Invite user with email" feature is not easily visible due to its dark shading.

How to reproduce the issue?

  1. Navigate to workspace settings.
  2. Select "Users" and then click "Add Users."
  3. Proceed to invite users via email.

Screenshots or Screencast

issue.in.dark.mode.mov

Any possible solutions?

To address this issue, we propose changing the icon color for the "Email" feature to white or a lighter shade when in dark mode.

If the bug is confirmed, would you be willing to submit a PR?

If this bug is confirmed, I am willing to submit a Pull Request to help resolve this issue.
@Akib-Vijapura Akib-Vijapura added the bug Something isn't working label Sep 27, 2023
Yash-rai-29 added a commit to Yash-rai-29/ToolJet that referenced this issue Sep 28, 2023
@Yash-rai-29
Dark mode issue for invite user with email ToolJet#7513
e6721fe
@Yash-rai-29 Yash-rai-29 linked a pull request Sep 28, 2023 that will close this issue
Open
@Damon248
Copy link
Contributor

Hello @Akib-Vijapura! I would like to work on this issue.

@Damon248
Copy link
Contributor

So, @Akib-Vijapura can you please assign me this task?

@Akib-Vijapura
Copy link
Author

Akib-Vijapura commented Sep 28, 2023 •
edited

Sorry @Damon248, I'm not a maintainer of this repo , but just go for it and make sure that It will work for both mode(Dark & Light).

@sharathkumar55
Copy link

Hi @Akib-Vijapura can i work on this issue to start my open source contribution

@thehacklady thehacklady added platform valid Vallid Issue labels Oct 18, 2023
@nechalmaggon nechalmaggon added roadmap and removed valid Vallid Issue labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working platform roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dark mode issue for invite user with email #7513 Yash-rai-29/ToolJet
5 participants
@thehacklady @Akib-Vijapura @Damon248 @sharathkumar55 @nechalmaggon