Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change a label related to workspace constants #9156

Open
karan-rathod-316 opened this issue Mar 21, 2024 · 8 comments · Fixed by #9218 · May be fixed by #9159
Open

Change a label related to workspace constants #9156

karan-rathod-316 opened this issue Mar 21, 2024 · 8 comments · Fixed by #9218 · May be fixed by #9159
Assignees
@joelali5
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs

Comments

@karan-rathod-316
Copy link
Collaborator

What is the expected behaviour?

The label for the Go to workspace constants button should read Go to Workspace constants

What is the current behaviour?

Currently it is Go to workspace constants

How to reproduce the issue?

  1. Go to Settings > Workspace settings > Workspace variables - You will find a Go to workspace constants button at the top (change it to Go to Workspace constants)

Screenshots or Screencast

image

If the bug is confirmed, would you be willing to submit a PR?

No
@karan-rathod-316 karan-rathod-316 added bug Something isn't working good first issue Good for newcomers up-for-grabs labels Mar 21, 2024
@joelali5
Copy link

Hi @karan-rathod-316 , I'm a first time contributor on this project, and I'd like to help out with this issue. Let me know please. Thank you.

@arp55 arp55 linked a pull request Mar 21, 2024 that will close this issue
Open
@arp55
Copy link

arp55 commented Mar 21, 2024

Hi @karan-rathod-316 . Have opened a PR for the same. Please check.

@karan-rathod-316
Copy link
Collaborator Author

Hi @joelali5, Assigning this to you. Happy Coding:-)

@karan-rathod-316
Copy link
Collaborator Author

@arp55 It would be great if you can get the issues assigned before raising a PR. Since @joelali5 was the first one to ask, I am assigning this to him. If the current assignee isn't able to complete it, I will consider your PR.

@arp55
Copy link

arp55 commented Mar 22, 2024

Sure, no problem

@joelali5
Copy link

Thanks @karan-rathod-316 I will open a PR for this shortly.

@joelali5
Copy link

@karan-rathod-316 After setting my development environment, I am unable to signup, below is the screenshot. Please let me know if you have an idea of what I need to do. Thank you

Screenshot 2024-03-22 at 14 06 56

@joelali5
Copy link

joelali5 commented Mar 22, 2024 •
edited

Hi @karan-rathod-316 I figured it out. I have raised a pull request, here: Edited the label for the workspace constants button #9171

@gsmithun4 gsmithun4 mentioned this issue Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joelali5 joelali5

Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs
Projects
None yet
Milestone
No milestone
3 participants
@joelali5 @arp55 @karan-rathod-316