Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --follow_symlink to ynh_secure_remove #1716

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add --follow_symlink to ynh_secure_remove #1716

wants to merge 2 commits into from

Conversation

Salamandar
Copy link
Contributor

The problem

yunohost/issues#2253

Solution

  • add --follow_symlink to ynh_secure_remove
  • Call readlink -f if --follow_symlink
  • test for file AND symlink existence.

PR Status

...

How to test

...

kay0u
kay0u reviewed Jan 18, 2024
View reviewed changes
helpers/utils
return
fi
if [[ "$follow_symlink" -eq 1 ]]; then
file=$(readlink -f "$file")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we don't remove the link?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kay0u kay0u kay0u left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Salamandar @kay0u