helpers: run composer as the app user #1808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah the issue is to not break every existing app... And some will break because file permissions are OK as root but nos as $app. That's a bit of the idea I had with this PR: #1717 where we could do point-release of the helpers and packages could target versions of the helpers (thus helping retrocompatibility AND evolution of the helpers). |
|
In the meantime the simple solution sounds like just introducing a new option to the helper so that it's backward compatible etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
YunoHost/issues#2367
we can't use
ynh_exec_as "$app" ynh_composer_execand composer cries about running as rootSolution
edit the
ynh_composer_execto run composer as the$appuserwe can't choose the user but idk if that would be a good thing: an app has to stay in its own box
PR Status
yolodone
How to test
...