Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] renew cert for sub subdomain #1819

Merged

Conversation

kay0u
Copy link
Member

@kay0u kay0u commented Apr 26, 2024

The problem

I receive mails:

An attempt for renewing the certificate for domain a.b.domain.tld failed with the following
error :

There is no diagnosis result for domain a.b.domain.tld yet. Please re-run a diagnosis for categories 'DNS records' and 'Web' in the diagnosis section to check if the domain is ready for Let's Encrypt. (Or if you know what you are doing, use '--no-checks' to turn off these checks.)

While the diagnosis is all green.

Solution

In _check_domain_is_ready_for_ACME we want the root domain instead of his closest parent to check dns records.

There is probably an edge case where domain a.b.domain.tld and b.domain.tld are on a server, and domain.tld is on another one

this edge case can be corrected by iterating on all parent domains. But is it really something?

PR Status

Done, tested on my server

How to test

...

@kay0u kay0u changed the title get the root domain instead of his closest parent [fix] renew cert for sub subdomain Apr 26, 2024
@alexAubin alexAubin merged commit c2c27a0 into dev May 18, 2024
2 of 3 checks passed
@alexAubin alexAubin deleted the fix-_check_domain_is_ready_for_ACME-for-sub-subdomain branch May 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants