[fix] renew cert for sub subdomain #1819
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
I receive mails:
While the diagnosis is all green.
Solution
In
_check_domain_is_ready_for_ACME
we want the root domain instead of his closest parent to check dns records.There is probably an edge case where domain a.b.domain.tld and b.domain.tld are on a server, and domain.tld is on another one
this edge case can be corrected by iterating on all parent domains. But is it really something?
PR Status
Done, tested on my server
How to test
...