Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor/Better base interface for models #245

Open
JasonShin opened this issue Jun 15, 2019 · 0 comments
Open

refactor/Better base interface for models #245

JasonShin opened this issue Jun 15, 2019 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@JasonShin
Copy link
Member

  • I'm submitting a ...
    [/] feature request

  • Summary
    As a result of BaggingClassifier work done by @OlegStotsky, we've realised that we need a better base interface that can represent the models. The ticket aims to refactor estimators, classifiers and models that are represented with any into a proper type.

As a reference, please look at ensemble/bagging.ts and the type of baseEstimator
@JasonShin JasonShin added enhancement New feature or request help wanted Extra attention is needed labels Jun 15, 2019
@JasonShin JasonShin mentioned this issue Jun 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JasonShin