Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra tests for multimodal combnation #459

Open
wants to merge 5 commits into
base: mainline
Choose a base branch
from

Conversation

wanliAlex
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    add extra tests for multimodal combination

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@wanliAlex wanliAlex marked this pull request as ready for review May 4, 2023 01:11
@wanliAlex wanliAlex requested a review from pandu-k May 4, 2023 01:11
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite May 4, 2023 01:14 — with GitHub Actions Inactive
Copy link
Collaborator

@pandu-k pandu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you please merge mainline back into this, (and use the the new AddDocsParam in add_docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants