Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rfc/testing repositories #2022

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

richardwardza
Copy link
Contributor

This is a request for comment and not to be merged.

I want to check a pattern I'm using when converting the tests to typescript.

With the update some of the data being used needs to be actual repositories and no longer "loose data". eg:

 const discount = {
        rule: {
          type: "percentage",
          value: 10,
        },
      }
     
      res = totalsService.getAllocationItemDiscounts(discount, cart)

Now needs to be :

      const discount = discountRepositoryMock.create({
        rule: {
          type: DiscountRuleType.PERCENTAGE,
          value: 10,
        },
      })

      res = totalsService.getAllocationItemDiscounts(discount, cart)

Is the pattern I have in this PR correct - I'm putting the discountRepositoryMock in the src/repositories/__mocks__/discount.js file (obviously that needs to be changed to ts too) ?

@richardwardza richardwardza requested a review from a team as a code owner August 10, 2022 07:57
@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2022

⚠️ No Changeset found

Latest commit: ccd7db5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant