chore(medusa): First crud service basic implementation #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3152fcd
to
5f06d47
Compare
5f06d47
to
bacdc92
Compare
467464d
to
5df587a
Compare
41b190e
to
0af2745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[PERSONAL TEST] Do not merge or review for now :) it is only a draft of my mind and could be a no go depending on discussion
Probably require the migration to typeorm 0.3 to continue and validate this one around a discussion
It is probable that this service will only includes common Read and Delete methods. For the create and update it could include a basic implementation that some services could use as well as the external users.
For the services that implement complex create/update they would still keep their own implementation since it is related to specific needs that we don't want to change and probably don't want to make generic since it could break the responsibilities which we want to avoid.
Depends on #2007 to improve it