Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete product image #5129

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

feat: delete product image #5129

wants to merge 10 commits into from
+388 −48

Conversation

bacarybruno
Copy link
Contributor

@bacarybruno bacarybruno commented Sep 19, 2023 •
edited

Details: #5149

This PR intends to remove product images and thumbnail when a product is updated or deleted.

Tasks:

  • Unit tests
  • Update documentation
  • Manual test the behaviour with medusa-file-local
  • Manual test the behaviour with medusa-file-s3
  • Manual test the behaviour with medusa-file-minio: need testers
  • Manual test the behaviour with medusa-file-spaces: need testers

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023 •
edited

⚠️ No Changeset found

Latest commit: ba0057d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 19, 2023

@bacarybruno is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@bacarybruno bacarybruno mentioned this pull request Sep 19, 2023
Open
olivermrbl
olivermrbl reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a feature that includes updating our core project config, please create a feature request in our GitHub Discussions, so we can discuss the approach. We'd like to avoid having long-running PRs open.

@pevey
Copy link
Contributor

pevey commented Sep 19, 2023

This has long been a pain point. I would love to see this implemented. The approach makes sense to me. It gives people the option to keep existing behavior if for some reason they want to keep images on delete.

@bacarybruno
Copy link
Contributor Author

Done here #5149 @olivermrbl 👍 do not hesitate to tell me if something else need to be done

@bacarybruno bacarybruno marked this pull request as ready for review September 19, 2023 17:39
@bacarybruno bacarybruno requested a review from a team as a code owner September 19, 2023 17:39
@bacarybruno bacarybruno marked this pull request as draft September 25, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bacarybruno @pevey @olivermrbl