Cursor movement is not always detected on double-width lines #17232
Labels
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Needs-Triage
It's a new issue that the core contributor team needs to triage at the next triage meeting
Comments
|
Hi I'm an AI powered bot that finds similar issues based off the issue title. Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you! Open similar issues:
Closed similar issues:
|
1 task
github-merge-queue bot
pushed a commit
that referenced
this issue
May 10, 2024
When the VT render engine checks whether the cursor has moved in the `InvalidateCursor` method, it does so by comparing the origin of the given cursor region with the last text output coordinates. But these two values are actually from different coordinate systems, and when on a double-width line, the x text coordinate is half of the corresponding screen coordinate. As a result, the movement detection is sometimes incorrect. This PR fixes the issue by adding another field to track the last cursor origin in screen coordinates, so we have a meaningful value to compare against. ## References and Relevant Issues The previous cursor movement detection was added in PR #17194 to fix issue #17117. ## Validation Steps Performed I've confirmed that the test case from issue #17232 is now fixed, and the test case from issue #17117 is still working as expected. ## PR Checklist - [x] Closes #17232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Windows Terminal version
1.21.1272.0
Windows build number
10.0.19045.4291
Other Software
No response
Steps to reproduce
Expected Behavior
This starts by setting the cursor style to a steady block so it's easy to see, then positions the cursor in column 11 and moves it left by 1 column every second until it reaches column 1.
Actual Behavior
When it gets to column 3 is pauses for 2 seconds before jumping to column 1. You never see the cursor in column 2.
This is because of the way conpty determines whether the cursor has moved in the
InvalidateCursormethod here:terminal/src/renderer/vt/invalidate.cpp
Line 78 in 49e4eea
The
psrRegionis in screen coordinates, while the_lastTextposition in buffer coordinates. So on a double-width line, when moving from column 3 to column 2, the_lastTextcolumn is 3, and thepsrRegion->originis also 3, because buffer column 2 spans screen columns 3 and 4. Thus it seems like no movement has occurred.This was another bug introduced by PR #17194.
The text was updated successfully, but these errors were encountered: